Skip to content

feat: activate DMQ protocol#2862

Merged
jpraynaud merged 9 commits into
mainfrom
jpraynaud/2833-activate-future-dmq
Dec 16, 2025
Merged

feat: activate DMQ protocol#2862
jpraynaud merged 9 commits into
mainfrom
jpraynaud/2833-activate-future-dmq

Conversation

@jpraynaud

@jpraynaud jpraynaud commented Dec 16, 2025

Copy link
Copy Markdown
Member

Content

This PR includes the activation of the DMQ protocol in the aggregator, signer and relay.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #2833

@jpraynaud jpraynaud self-assigned this Dec 16, 2025
@github-actions

github-actions Bot commented Dec 16, 2025

Copy link
Copy Markdown

Test Results

    4 files  ±0    172 suites  ±0   23m 7s ⏱️ -53s
2 274 tests ±0  2 274 ✅ ±0  0 💤 ±0  0 ❌ ±0 
7 137 runs  ±0  7 137 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 902e2a0. ± Comparison against base commit aee9032.

♻️ This comment has been updated with latest results.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR activates the DMQ (Decentralized Message Queue) protocol across the Mithril aggregator, signer, and relay components by removing the future_dmq feature flag that was previously gating this functionality. The changes also include an upgrade of the Pallas library dependencies from version 0.33.0 to 0.34.0.

Key Changes:

  • Removal of all #[cfg(feature = "future_dmq")] conditional compilation directives, making DMQ support unconditional
  • Conversion of mithril-dmq from an optional dependency to a required dependency in affected crates
  • Upgrade of Pallas library dependencies from 0.33.0 to 0.34.0
  • Addition of CI test configuration for DMQ protocol with fake DMQ node

Reviewed changes

Copilot reviewed 23 out of 24 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
mithril-test-lab/mithril-end-to-end/Cargo.toml Version bump to 0.4.111
mithril-test-lab/mithril-end-to-end/src/main.rs Removed comment about future_dmq feature requirement
mithril-signer/Cargo.toml Version bump to 0.2.282, removed future_dmq feature, made mithril-dmq a required dependency
mithril-signer/src/main.rs Removed comment about conditional signature publishing based on feature flag
mithril-signer/src/configuration.rs Removed #[cfg(feature = "future_dmq")] from imports and methods
mithril-signer/src/dependency_injection/builder.rs Removed all conditional compilation for DMQ support, eliminated non-DMQ code path
mithril-signer/src/services/signature_publisher/mod.rs Removed feature flag guards from DMQ module exports
mithril-relay/Cargo.toml Version bump to 0.1.56, removed future_dmq feature, made mithril-dmq a required dependency
mithril-relay/src/commands/aggregator.rs Removed feature flag guards from DMQ-related imports and parameters
mithril-relay/src/commands/signer.rs Removed feature flag guards from DMQ-related imports and parameters
mithril-relay/src/p2p/peer.rs Removed feature flag guard from DMQ message enum variant and method
mithril-relay/src/relay/aggregator.rs Removed all DMQ-related feature flags and non-DMQ code paths
mithril-relay/src/relay/passive.rs Removed feature flag guard from DMQ signature message handling
mithril-relay/src/relay/signer.rs Removed all DMQ-related feature flags and non-DMQ code paths
mithril-relay/tests/register_signer_signature.rs Removed feature flag guards from test code
mithril-aggregator/Cargo.toml Version bump to 0.7.97, removed future_dmq feature, made mithril-dmq a required dependency
mithril-aggregator/src/configuration.rs Removed feature flag guards from DMQ configuration methods
mithril-aggregator/src/dependency_injection/builder/enablers/misc.rs Removed feature flags and non-DMQ code path from signature consumer builder
mithril-aggregator/src/services/signature_consumer/mod.rs Removed feature flag guards from DMQ module exports
internal/mithril-dmq/Cargo.toml Version bump to 0.1.16, upgraded Pallas dependencies from git branch to version 0.34.0
internal/cardano-node/mithril-cardano-node-chain/Cargo.toml Version bump to 0.1.12, upgraded Pallas dependencies from 0.33.0 to 0.34.0
Cargo.lock Updated dependency graph reflecting Pallas 0.34.0 upgrade and version bumps
CHANGELOG.md Added entry for DMQ protocol support
.github/workflows/ci.yml Removed future_dmq from test feature flags, added E2E test with fake DMQ node

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread CHANGELOG.md
@jpraynaud
jpraynaud marked this pull request as ready for review December 16, 2025 10:14
@jpraynaud
jpraynaud requested a review from Alenar December 16, 2025 10:14

@Alenar Alenar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

I think we should bump the minor version of the aggregator, relay and signer.

* mithril-cardano-node-chain from `0.1.11` to `0.1.12`
* mithril-dmq from `0.1.15` to `0.1.16`
* mithril-aggregator from `0.7.96` to `0.8.0`
* mithril-relay from `0.1.55` to `0.2.0`
* mithril-signer from `0.2.281` to `0.3.0`
* mithril-end-to-end from `0.4.110` to `0.4.111`
@jpraynaud
jpraynaud force-pushed the jpraynaud/2833-activate-future-dmq branch from 7ff2413 to 902e2a0 Compare December 16, 2025 11:23
@jpraynaud
jpraynaud merged commit ad2ce7b into main Dec 16, 2025
108 of 109 checks passed
@jpraynaud
jpraynaud deleted the jpraynaud/2833-activate-future-dmq branch December 16, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants