Skip to content

feat: add "total successful" metrics for signature and signer registrations#2865

Merged
Alenar merged 4 commits into
mainfrom
djo/2855/aggregator/better-signer-signature-metrics
Dec 17, 2025
Merged

feat: add "total successful" metrics for signature and signer registrations#2865
Alenar merged 4 commits into
mainfrom
djo/2855/aggregator/better-signer-signature-metrics

Conversation

@Alenar

@Alenar Alenar commented Dec 16, 2025

Copy link
Copy Markdown
Collaborator

Content

This PR add two new metrics to the aggregator:

  • signer_registration_total_successful_since_startup
  • signature_registration_total_successful_since_startup

Crossed with the existing "total received" metrics allow to track success or failure of signature and signer registrations using the aggregator Prometheus metrics.

Also:

  • Fix SignatureProcessor only incrementing metric signature_registration_total_received_since_startup on signature registration success (which is covered by the new metric) instead of when it have been acknowledge by the system.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • No new TODOs introduced

Issue(s)

Closes #2855

@Alenar
Alenar requested a review from jpraynaud December 16, 2025 19:15
@Alenar Alenar self-assigned this Dec 16, 2025
@Alenar Alenar added the optimization 🛠️ Optimization and/or small enhancements label Dec 16, 2025
@github-actions

github-actions Bot commented Dec 16, 2025

Copy link
Copy Markdown

Test Results

    4 files  ±0    169 suites  ±0   23m 2s ⏱️ +30s
2 275 tests +4  2 275 ✅ +4  0 💤 ±0  0 ❌ ±0 
7 136 runs  +8  7 136 ✅ +8  0 💤 ±0  0 ❌ ±0 

Results for commit 3b3440c. ± Comparison against base commit ac2db70.

This pull request removes 2 and adds 6 tests. Note that renamed tests count towards both.
mithril-aggregator ‑ http_server::routes::signatures_routes::tests::test_register_signatures_increments_signature_registration_total_received_since_startup_metric
mithril-aggregator ‑ http_server::routes::signer_routes::tests::test_register_signer_post_increments_signer_registration_total_received_since_startup_metric
mithril-aggregator ‑ http_server::routes::signatures_routes::tests::test_register_signatures_increments_signature_registration_total_received_and_successful_since_startup_metric_if_successful
mithril-aggregator ‑ http_server::routes::signatures_routes::tests::test_register_signatures_only_increments_signature_registration_total_received_since_startup_metric_if_failure
mithril-aggregator ‑ http_server::routes::signer_routes::tests::test_register_signer_increments_signer_registration_total_received_and_successful_since_startup_metric_if_successful
mithril-aggregator ‑ http_server::routes::signer_routes::tests::test_register_signer_only_increments_signer_registration_total_received_since_startup_metric_if_failure
mithril-aggregator ‑ services::signature_processor::tests::processor_process_signatures_send_only_total_received_statistic_if_failure
mithril-aggregator ‑ services::signature_processor::tests::processor_process_signatures_send_total_received_and_successful_statistics_if_successful

♻️ This comment has been updated with latest results.

@Alenar
Alenar temporarily deployed to testing-preview December 16, 2025 19:26 — with GitHub Actions Inactive
* mithril-aggregator from `0.8.1` to `0.8.2`
@Alenar
Alenar force-pushed the djo/2855/aggregator/better-signer-signature-metrics branch from f63b365 to 3b3440c Compare December 17, 2025 09:30
@Alenar
Alenar temporarily deployed to testing-preview December 17, 2025 09:40 — with GitHub Actions Inactive

@jpraynaud jpraynaud left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Alenar
Alenar merged commit ecad03d into main Dec 17, 2025
60 checks passed
@Alenar
Alenar deleted the djo/2855/aggregator/better-signer-signature-metrics branch December 17, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

optimization 🛠️ Optimization and/or small enhancements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance signer/signature registration metrics in aggregator

2 participants