feat: add "total successful" metrics for signature and signer registrations#2865
Merged
Alenar merged 4 commits intoDec 17, 2025
Merged
Conversation
Test Results 4 files ±0 169 suites ±0 23m 2s ⏱️ +30s Results for commit 3b3440c. ± Comparison against base commit ac2db70. This pull request removes 2 and adds 6 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Alenar
temporarily deployed
to
testing-preview
December 16, 2025 19:26 — with
GitHub Actions
Inactive
…`SignatureProcessor`
* mithril-aggregator from `0.8.1` to `0.8.2`
Alenar
force-pushed
the
djo/2855/aggregator/better-signer-signature-metrics
branch
from
December 17, 2025 09:30
f63b365 to
3b3440c
Compare
Alenar
temporarily deployed
to
testing-preview
December 17, 2025 09:40 — with
GitHub Actions
Inactive
Alenar
deleted the
djo/2855/aggregator/better-signer-signature-metrics
branch
December 17, 2025 10:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
This PR add two new metrics to the aggregator:
signer_registration_total_successful_since_startupsignature_registration_total_successful_since_startupCrossed with the existing "total received" metrics allow to track success or failure of signature and signer registrations using the aggregator Prometheus metrics.
Also:
SignatureProcessoronly incrementing metricsignature_registration_total_received_since_startupon signature registration success (which is covered by the new metric) instead of when it have been acknowledge by the system.Pre-submit checklist
Issue(s)
Closes #2855