ci: fix aggregator stress test parameters handling#2900
Merged
Conversation
…en triggered by workflow call It used the workflow inputs directly instead of the prepare steps values. If the workflow was called by another workflow (such as the nightly dispatcher), this makes the commit and branch values both empty when downloading the aggregator binary, making the `dawidd6/action-download-artifact` download the latest generated artifacts (which is often one from a branch) instead of the one from the latest main branch merge.
…onal as it will fallback to the main branch if missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
This PR fixes arguments handling in the aggregator stress test ci workflow:
commit_shato use the branchmain: if it was missing, themainbranch would only be used to download the end to end runner binary, for the aggregator binary the artifact of the latestci.ymlrun was used.commit_shato download binary steps: if it was provided it was correctly used only to download the aggregator binary, for the end to end runner the artifact of the latestci.ymlrun was used.commit_shanot mandatory to allow the fallback to themainbranch even when running the worflow manuallyPre-submit checklist
Issue(s)
Closes #2879