Golden test for Closed Key Registration#2901
Merged
Merged
Conversation
curiecrypt
temporarily deployed
to
testing-preview
January 9, 2026 15:39 — with
GitHub Actions
Inactive
curiecrypt
marked this pull request as ready for review
January 9, 2026 15:41
curiecrypt
requested review from
Copilot and
jpraynaud
and removed request for
Copilot
January 9, 2026 15:41
There was a problem hiding this comment.
Pull request overview
This PR adds a golden test to verify the serialization and deserialization of the Merkle tree batch commitment for closed key registration. The test ensures that the serialization format remains stable across versions.
Key Changes
- Added golden test module with serialization/deserialization verification for
MerkleTreeBatchCommitmentin the closed key registration flow - Bumped version from 0.9.1 to 0.9.2
- Updated CHANGELOG to document the new golden test
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| mithril-stm/src/protocol/key_registration.rs | Adds new golden test module with golden_value() helper and golden_conversions() test to verify serialization consistency of Merkle tree batch commitment |
| mithril-stm/Cargo.toml | Updates version from 0.9.1 to 0.9.2 |
| mithril-stm/CHANGELOG.md | Adds entry for version 0.9.2 documenting the new golden test |
| Cargo.lock | Updates version reference to match Cargo.toml change |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
This PR includes golden test for the Merkle tree batch commitment of the closed key registration.
Pre-submit checklist
Comments
Issue(s)
Relates to #2880