feat: add ConfigSecret type and use it for aggregator blockfrost configuration#2919
Merged
Conversation
To allow safe usage of secrets in configuration values. Before we needed to introduce indirection to store them in another source (e.g. in a env var which only the name was given to the config).
…ypes As they are only meant to be read, not write.
…ct_id` Instead of an indirection using an environement variable.
Alenar
temporarily deployed
to
testing-preview
January 13, 2026 11:33 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
* mithril-aggregator from `0.8.7` to `0.8.8` * mithril-common from `0.6.40` to `0.6.41` * mithril-signer from `0.3.2` to `0.3.3`
Alenar
temporarily deployed
to
testing-preview
January 13, 2026 11:55 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
This PR add a new
ConfigSecrettype and use it for aggregator blockfrost configuration.The
ConfigSecretredact the wrapped value in print, logs, and serialization, but is only designed to fit the configuration de-serialization case.As such it should be no used in other context, or if this is needed its security should be strengthened.
Note
This PR also remove the ability to serialize the aggregator and signer configuration structs since we only need to read them, not write, this has no impact as this capacity was not used.
Pre-submit checklist
Issue(s)
Relates to #2878