refactor(stm): Remove possibility of panic during conversion from KeyRegistration to MerkleTree #2959
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
damrobi
temporarily deployed
to
testing-preview
January 26, 2026 19:10 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
hjeljeli32
approved these changes
Jan 27, 2026
hjeljeli32
left a comment
hjeljeli32
left a comment
Collaborator
There was a problem hiding this comment.
LGMT.
I just left 2 non-blocking comments.
Collaborator
Author
|
As @hjeljeli32 noted in his comment, I added a few unwraps in the code outside of the STM library where I thought we were in test environment. I will check again that it is indeed the case but please have a look at that during your review |
jpraynaud
changed the title
From trait with TryFrom for AggregateVerificationKeyForConcatenation conversionTryFrom for AggregateVerificationKeyForConcatenation conversion
damrobi
force-pushed
the
damrobi/msnark/replace-into-impl-avkforconcat
branch
from
January 28, 2026 11:52
d66d22a to
41d1dfe
Compare
damrobi
changed the title
TryFrom for AggregateVerificationKeyForConcatenation conversionKeyRegistration to MerkleTree
damrobi
temporarily deployed
to
testing-preview
January 28, 2026 12:03 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
damrobi
marked this pull request as ready for review
January 29, 2026 16:26
damrobi
force-pushed
the
damrobi/msnark/replace-into-impl-avkforconcat
branch
from
January 29, 2026 16:28
89a8d1d to
6090068
Compare
damrobi
temporarily deployed
to
testing-preview
January 29, 2026 16:40 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
damrobi
force-pushed
the
damrobi/msnark/replace-into-impl-avkforconcat
branch
from
January 30, 2026 08:30
6090068 to
2fceaf2
Compare
damrobi
temporarily deployed
to
testing-preview
January 30, 2026 08:45 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
This PR includes a refactoring to remove the possibility of panicking during the conversion from
KeyRegistrationtoMerkleTree. This includes the current conversion for concatenation and the future conversion for SNARK.Pre-submit checklist
Comments
Issue(s)
Relates to #2954