Skip to content

fix: panic at startup in aggregator#3024

Merged
jpraynaud merged 2 commits into
mainfrom
ensemble/3023-fix-panic-aggregator
Feb 20, 2026
Merged

fix: panic at startup in aggregator#3024
jpraynaud merged 2 commits into
mainfrom
ensemble/3023-fix-panic-aggregator

Conversation

@jpraynaud

@jpraynaud jpraynaud commented Feb 20, 2026

Copy link
Copy Markdown
Member

Content

This PR includes a fix for a panic occurring at aggregator startup following dependencies upgrade.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #3023

@jpraynaud jpraynaud self-assigned this Feb 20, 2026
@jpraynaud jpraynaud changed the title Ensemble/3023 fix panic aggregator fix: panic at startup in aggregator Feb 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a startup panic in mithril-aggregator after Rust dependency upgrades by attempting to force a specific rustls crypto provider selection via Cargo features.

Changes:

  • Bump mithril-aggregator crate version from 0.8.25 to 0.8.26.
  • Add an explicit rustls dependency (with ring feature) to influence provider selection.
  • Update Cargo.lock to reflect the new direct dependency and associated resolution changes.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
mithril-aggregator/Cargo.toml Bumps crate version and adds an explicit rustls dependency configured for ring.
Cargo.lock Updates the lockfile to include rustls as a direct dependency of mithril-aggregator and refreshes resolved deps.

Comment thread mithril-aggregator/Cargo.toml Outdated
@github-actions

github-actions Bot commented Feb 20, 2026

Copy link
Copy Markdown

Test Results

    5 files  ±0    172 suites  ±0   41m 58s ⏱️ - 3m 29s
2 606 tests ±0  2 606 ✅ ±0  0 💤 ±0  0 ❌ ±0 
8 117 runs  ±0  8 117 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5468ea0. ± Comparison against base commit c72cd42.

♻️ This comment has been updated with latest results.

@jpraynaud
jpraynaud force-pushed the ensemble/3023-fix-panic-aggregator branch from ef6c811 to d3c7983 Compare February 20, 2026 13:03
Fixed by forcing the 'ring' feature on 'rustls' which was apparently
missing following dependency upgrade.
* mithril-aggregator from `0.8.25` to `0.8.26`
@jpraynaud
jpraynaud force-pushed the ensemble/3023-fix-panic-aggregator branch from d3c7983 to 5468ea0 Compare February 20, 2026 13:38

@turmelclem turmelclem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpraynaud
jpraynaud merged commit 71c0de5 into main Feb 20, 2026
58 checks passed
@jpraynaud
jpraynaud deleted the ensemble/3023-fix-panic-aggregator branch February 20, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Aggregator in testing-preview panics at startup

4 participants