refactor+test: prover preparatory work

[Alenar]

Content

This PR includes refactors and new tests utilities that will be used for the upcoming blocks and transactions prover.

• refactor: extract CardanoBlockTransactionMkTreeNode to a dedicated file module
• multiple improvements for InMemoryChainDataStore (mithril-cardano-node-chain) in order to be able to use it in the upcoming prover tests:
  • impl mithril_common::signable_builder::BlockRangeRootRetriever
  • new retrieval methods: get_blocks_by_hashes, get_transactions_by_hashes, get_blocks_with_transactions_in_block_ranges, get_blocks_with_transactions_in_ranges
  • add compute_block_ranges to its builder to generate realistic block ranges root, avoiding the need to provide them manually (which is still an option)
• refactor CardanoTransactionsBuilder (mithril-common):
  • rename build_block_ranges to build_transactions_for_block_ranges: to avoid confusion with a new method
  • new build_blocks and build_blocks_for_block_ranges that produces CardanoBlockWithTransactions instead of CardanoTransaction
  • refactor internal mechanisms to works on blocks, allowing a shared logic between old an new functions
  • group tests for each of the builders output with a module

Pre-submit checklist

• Branch
  • Tests are provided (if possible)
  • Crates versions are updated (if relevant)
  • Commit sequence broadly makes sense
  • Key commits have useful messages
• PR
  • All check jobs of the CI have succeeded
  • Self-reviewed the diff
  • Useful pull request description
  • Reviewer requested
• Documentation
  • No new TODOs introduced

Issue(s)

Relates to #2987

[github-actions]

Test Results

    5 files  ± 0    190 suites  ±0   57m 53s ⏱️ + 1m 41s
2 671 tests +18  2 671 ✅ +18  0 💤 ±0  0 ❌ ±0 
9 586 runs  +81  9 586 ✅ +81  0 💤 ±0  0 ❌ ±0 

Results for commit f41e270. ± Comparison against base commit 925875b.

This pull request removes 25 and adds 43 tests. Note that renamed tests count towards both.

mithril-cardano-node-chain ‑ test::double::chain_data_store::tests::get_blocks_and_transactions_in_range_filters_correctly
mithril-cardano-node-chain ‑ test::double::chain_data_store::tests::get_blocks_and_transactions_in_range_returns_empty_when_store_empty
mithril-common ‑ entities::cardano_block::tests::block_node_leaf_identifier
mithril-common ‑ entities::cardano_block::tests::convert_block_node_into_mktree_nodes
mithril-common ‑ entities::cardano_block::tests::convert_tx_node_into_mktree_nodes
mithril-common ‑ entities::cardano_block::tests::mk_tree_node_ordering::order_block_nodes_first_then_transaction_nodes
mithril-common ‑ entities::cardano_block::tests::mk_tree_node_ordering::order_blocks_by_block_hash_third
mithril-common ‑ entities::cardano_block::tests::mk_tree_node_ordering::order_blocks_by_block_number_first
mithril-common ‑ entities::cardano_block::tests::mk_tree_node_ordering::order_blocks_by_slot_number_second
mithril-common ‑ entities::cardano_block::tests::mk_tree_node_ordering::order_transactions_by_block_hash_third
…

mithril-cardano-node-chain ‑ test::double::chain_data_store::tests::builder_can_compute_block_range_roots
mithril-cardano-node-chain ‑ test::double::chain_data_store::tests::get_blocks_by_hashes_filters_correctly
mithril-cardano-node-chain ‑ test::double::chain_data_store::tests::get_blocks_with_transactions_in_ranges_filters_correctly
mithril-cardano-node-chain ‑ test::double::chain_data_store::tests::get_blocks_with_transactions_in_ranges_returns_empty_when_store_empty
mithril-cardano-node-chain ‑ test::double::chain_data_store::tests::get_transactions_by_hashes_filters_correctly
mithril-cardano-node-chain ‑ test::double::chain_data_store::tests::retrieve_blocks_range_root::returns_empty_when_store_empty
mithril-cardano-node-chain ‑ test::double::chain_data_store::tests::retrieve_blocks_range_root::up_to_above_all_stored_ranges_returns_all
mithril-cardano-node-chain ‑ test::double::chain_data_store::tests::retrieve_blocks_range_root::up_to_below_start_of_the_first_range_returns_nothing
mithril-cardano-node-chain ‑ test::double::chain_data_store::tests::retrieve_blocks_range_root::up_to_right_after_start_of_the_third_range_returns_the_first_three_ranges
mithril-cardano-node-chain ‑ test::double::chain_data_store::tests::retrieve_blocks_range_root::up_to_right_at_start_of_the_third_range_returns_the_first_two_ranges
…

♻️ This comment has been updated with latest results.

[Copilot]

Pull request overview

This PR is preparatory work for an upcoming blocks and transactions prover (tracking issue #2987). It cleans up the existing code and adds new test utilities so they can be used in future prover tests.

Changes:

• Extract CardanoBlockTransactionMkTreeNode from cardano_block.rs into its own dedicated module, and add a From<CardanoBlockWithTransactions> for CardanoBlock conversion.
• Refactor CardanoTransactionsBuilder in mithril-common: rename build_block_ranges to build_transactions_for_block_ranges, change slot number generation from per-transaction to per-block, and add new build_blocks / build_blocks_for_block_ranges methods that produce CardanoBlockWithTransactions.
• Enhance InMemoryChainDataStore in mithril-cardano-node-chain: add get_blocks_by_hashes, get_transactions_by_hashes, get_blocks_with_transactions_in_block_ranges, get_blocks_with_transactions_in_ranges, implement BlockRangeRootRetriever, and add a compute_block_ranges builder method.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
mithril-common/src/entities/cardano_block_transaction_mktree_node.rs	New file: extracted CardanoBlockTransactionMkTreeNode type and all its tests from cardano_block.rs.
mithril-common/src/entities/cardano_block.rs	Removed CardanoBlockTransactionMkTreeNode (now extracted); added From<CardanoBlockWithTransactions> for CardanoBlock.
mithril-common/src/entities/mod.rs	Re-exports the new cardano_block_transaction_mktree_node module.
mithril-common/src/test/builder/cardano_transactions_builder.rs	Major refactor: new block-centric builder logic; renamed method; new build_blocks* methods; reorganized tests into sub-modules.
internal/cardano-node/mithril-cardano-node-chain/src/test/double/chain_data_store.rs	New retrieval methods, BlockRangeRootRetriever impl, and compute_block_ranges builder method; new and updated tests.
internal/cardano-node/mithril-cardano-node-chain/src/chain_importer/mod.rs	Exposes BlockRangeImporter as pub(crate) for use in the test double.
mithril-aggregator/src/services/prover_legacy.rs	Updates test calls from build_block_ranges to the renamed build_transactions_for_block_ranges.

[jpraynaud]

LGTM 👍

[turmelclem]

LGTM 👍