feat: enforce DMQ message id#3256
Merged
Merged
Conversation
Which follows the specification of CIP-0137.
* mithril-dmq from `0.1.23` to `0.1.24`
There was a problem hiding this comment.
Pull request overview
This PR updates the DMQ message ID computation to enforce the strict CIP-0137 format by switching to a deterministic Blake2b_256(msg_body || expires_at.to_be_bytes()) digest (removing the previous inclusion of kes_period and changing the hash output size accordingly).
Changes:
- Switched DMQ message ID hashing from
Blake2b_512(includingkes_period) toBlake2b_256overmsg_body+ big-endianexpires_at. - Added a golden test vector to lock the message ID computation.
- Bumped
mithril-dmqcrate version and documented the change inCHANGELOG.md.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/mithril-dmq/src/model/builder.rs | Updates message ID computation to CIP-0137 and adds a golden vector test. |
| internal/mithril-dmq/Cargo.toml | Bumps mithril-dmq version to 0.1.24. |
| CHANGELOG.md | Records the DMQ message ID format enforcement change. |
| Cargo.lock | Updates lockfile for the mithril-dmq version bump. |
Test Results 5 files 203 suites 50m 54s ⏱️ Results for commit 600492c. |
Alenar
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
This PR includes a new computation of the DMQ message id, enforcing the strict format specified in CIP-0137.
The message id is now computed as
Blake2b_256(msg_body || expires_at.to_be_bytes()), replacing the previousBlake2b_512digest that also incorporatedkes_period.Pre-submit checklist
Issue(s)
Relates to #3251