fix(e2e): fix flakiness with minimal scenario - #3475
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts Mithril e2e “minimal” mode configuration to reduce CI flakiness caused by certificates being sealed with an incomplete signer set.
Changes:
- Tune
ProtocolParameters.phi_fforAggregateSignatureType::Concatenationto improve stability in minimal-mode e2e runs. - Bump
mithril-end-to-endcrate version to0.5.11(and updateCargo.lockaccordingly).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| mithril-test-lab/mithril-end-to-end/src/mithril/infrastructure.rs | Updates protocol parameters used when starting the e2e infrastructure with concatenation signatures. |
| mithril-test-lab/mithril-end-to-end/Cargo.toml | Bumps mithril-end-to-end version to 0.5.11. |
| Cargo.lock | Updates locked version for mithril-end-to-end to 0.5.11. |
Lower 'phi_f' to 0.77 so a single signer no longer wins enough lotteries on its own, which made certificates seal with an incomplete signer set.
* mithril-end-to-end from `0.5.10` to `0.5.11`
fcf959e to
4c27b8b
Compare
Alenar
left a comment
There was a problem hiding this comment.
LGTM, what about the stability of networks with more than two signers?
It's not possible to craft a single set of parameters that will fit all number of signers with the constraints we have today that they all have their signature used to create the multi-signature. The new parameters work for 2 signers but will likely not work for more. We probably need to relax the assumption that all signers need to sign all certificates and check that they all signed at least one certificate (as we have previously discussed). |
Content
This PR includes a fix for the flakiness of the e2e test in
minimalmode, where certificates could be sealed with an incomplete signer set.The new protocol parameters are crafted to avoid having one signer reach the quorum alone which lead to the
Certificate is not signed by expected number of signers: 1 < 2error. The success rate witnessed on my local environment increased from 75% to 100% with the new protocol parameters.Pre-submit checklist
Issue(s)
Relates to #3452