You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for picking this up — the shape is exactly what I had in mind, and the keyed-destructuring is a nice addition.
One small thing on Size::offsetGet: the default branch throws \ErrorException. That's conventionally reserved for error-handler-converted PHP errors. For "unknown offset on a read-only ArrayAccess object," PHP's stdlib convention is \OutOfBoundsException (or \InvalidArgumentException — which is also what Size's constructor uses for negative width/height in this codebase). Happy to send a small PR against your branch if useful.
I see what you mean. I don't think InvalidArgumentException is quite the right choice here, since this isn't a function argument in the traditional sense and the exception is for semantically for bad function/method arguments.
I replaced it with RuntimeException, which matches the other ArrayAccess methods and keeps it in the libraries exception hierarchy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By decoupling Size from Polygon.
Closes #1480