Skip to content

CI fixes #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 15, 2021
Merged

CI fixes #56

merged 3 commits into from
Jun 15, 2021

Conversation

@cjyar
Copy link
Contributor

@cjyar cjyar commented Jun 14, 2021

  • Only run coverage once, and only if on a PR. Missed this in my original PR because the bug only occurs when running on main.
  • Upload to the upload URL. I thought I fixed this in my original PR, but probably reverted it by mistake when I reverted hard-coded values used for testing.

@cjyar cjyar added the ops label Jun 14, 2021
@cjyar cjyar self-assigned this Jun 14, 2021
@cjyar cjyar requested a review from a team as a code owner June 14, 2021 22:05
@github-actions
Copy link

github-actions bot commented Jun 14, 2021

No changes to code coverage between the base branch and the head branch

16 similar comments
@github-actions
Copy link

github-actions bot commented Jun 14, 2021

No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

github-actions bot commented Jun 14, 2021

No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

github-actions bot commented Jun 14, 2021

No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

github-actions bot commented Jun 14, 2021

No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

github-actions bot commented Jun 14, 2021

No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

github-actions bot commented Jun 14, 2021

No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

github-actions bot commented Jun 14, 2021

No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

github-actions bot commented Jun 14, 2021

No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

github-actions bot commented Jun 14, 2021

No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

github-actions bot commented Jun 14, 2021

No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

github-actions bot commented Jun 14, 2021

No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

github-actions bot commented Jun 14, 2021

No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

github-actions bot commented Jun 14, 2021

No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

github-actions bot commented Jun 14, 2021

No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

github-actions bot commented Jun 14, 2021

No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

github-actions bot commented Jun 14, 2021

No changes to code coverage between the base branch and the head branch

@github-actions
Copy link

github-actions bot commented Jun 14, 2021

No changes to code coverage between the base branch and the head branch

1 similar comment
@github-actions
Copy link

github-actions bot commented Jun 14, 2021

No changes to code coverage between the base branch and the head branch

@BobWall23 BobWall23 merged commit 9a3e687 into main Jun 15, 2021
@BobWall23 BobWall23 deleted the ci-fixes branch June 15, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BobWall23 BobWall23 BobWall23 approved these changes

@giarc3 giarc3 giarc3 approved these changes

Assignees

@cjyar cjyar

Labels

ops

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cjyar @BobWall23 @giarc3