Use www.python.org for testing _ssl - #1464
Merged
Merged
Conversation
slozier
approved these changes
May 21, 2022
slozier
left a comment
slozier
left a comment
Contributor
There was a problem hiding this comment.
Awesome! Hopefully that resolves the SSL failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces www.microsoft.com with www.python.org as the site used for the SSl tests. It will hopefully stop the intermittent
test__sslfailures during CI.The failures were in
test_SSLType_read_and_writeduring an attempt to read. At first I thought this might be a bug in the implementation of_sslbut it turned out that CPython exhibits the same behaviour (i.e. hangs indefinitely). My best guess now is that www.microsoft.com deploys some sophisticated anti-bot defences that hinder the automatic test. www.python.org seems to respond just fine, even during a repeated test run.