Fixes issues with required params in responses.#4
Merged
Conversation
The latest Swagger Codegen has added some parameter validation that causes problems with parameters that are not required. Specifically, if the PAPI responds with a "null" value for a particular parameter that has some type of input validation then it would fail the validation because the validation code did not know how to account for a value being set to None, but now it does, which for non-required parameters it should be ok to do. There were also some issues with some of the data model definitions having more required parameters than necessary. So that issue is fixed too. That caused the creation of new data model defintions. Lastly, I updated the version number of the package to 1.0.1 and I added a setup_venv.sh that makes it easy to install the package in a virtual environment in order to test it out before fully installing it.
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest Swagger Codegen has added some parameter validation that
causes problems with parameters that are not required. Specifically, if
the PAPI responds with a "null" value for a particular parameter that
has some type of input validation then it would fail the validation
because the validation code did not know how to account for a value
being set to None, but now it does, which for non-required parameters it
should be ok to do.
There were also some issues with some of the data model definitions
having more required parameters than necessary. So that issue is fixed
too. That caused the creation of new data model defintions.
Lastly, I updated the version number of the package to 1.0.1 and I added
a setup_venv.sh that makes it easy to install the package in a virtual
environment in order to test it out before fully installing it.