-
Notifications
You must be signed in to change notification settings - Fork 33
Set payload data onReceive #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set payload data onReceive #50
Conversation
|
|
||
| String actionName = intent.getAction(); | ||
| if (IterableConstants.ACTION_PUSH_ACTION.equalsIgnoreCase(actionName)) { | ||
| IterableApi.sharedInstance.setPayloadData(intent); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to move this to line 84, before the calls to setNotificationData and trackPushOpen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! Taken care of
e7fefdb to
2a1e50c
Compare
|
Awesome, thank you for catching that @steelbrain! |
|
@vbabenkoru Thoughts on a new method Currently we have to get each payload key one by one and it cannot be used, which doesn't work if keys are dynamic (unless we wrap the dynamic top level keys into a namespace object like "tb") |
|
Yeah, we can add |
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
=========================================
+ Coverage 54.26% 54.66% +0.4%
=========================================
Files 24 24
Lines 1360 1361 +1
Branches 142 142
=========================================
+ Hits 738 744 +6
+ Misses 532 526 -6
- Partials 90 91 +1
Continue to review full report at Codecov.
|
setPayloadDatawas defined but wasn't being used. This makes sure to set the payload data on GCM messages