Skip to content

Conversation

@steelbrain
Copy link

Adds a new method that returns all of payload as a JSONObject. It handles JSON errors the same way other methods do in this file.

Context: #50 (comment)

@vbabenkoru
Copy link
Contributor

Thanks! Isn't it enough to just return a Bundle?

@steelbrain
Copy link
Author

Bundle works, I did JSON because it's specific to my usecase but I think the conversion could live in consumerland

Updated!

@steelbrain steelbrain force-pushed the steelbrain/get-all-payload-data branch from 06a941e to 1109f75 Compare July 26, 2018 22:34
@codecov
Copy link

codecov bot commented Jul 26, 2018

Codecov Report

Merging #51 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
- Coverage   54.66%   54.62%   -0.05%     
==========================================
  Files          24       24              
  Lines        1361     1362       +1     
  Branches      142      142              
==========================================
  Hits          744      744              
- Misses        526      527       +1     
  Partials       91       91
Impacted Files Coverage Δ
...ain/java/com/iterable/iterableapi/IterableApi.java 48.78% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a22a9...1109f75. Read the comment docs.

@vbabenkoru
Copy link
Contributor

By the way, do you only need this within one app session? In the iOS version of the SDK, we store the push payload for 24 hours.

@steelbrain
Copy link
Author

Yes the payloads are instantly sent to React Native world where they are dealt with

@vbabenkoru vbabenkoru merged commit 56831b3 into Iterable:master Jul 26, 2018
@steelbrain steelbrain deleted the steelbrain/get-all-payload-data branch July 27, 2018 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants