Check this fork for updates, not the repository it was forked from - #14
Merged
Conversation
Both updaters queried itsspin/spinips, and electron-builder's publish target named it too. A build of this fork therefore asked upstream what the newest release was: for the desktop app that is a release whose Linux artifacts do not exist upstream at all, and for the SpinUI skins it is a different set of skin files from the ones this fork builds and ships. The release assets each updater wants -- Loremaster.exe for the app, and SpinUI-UI.zip, SpinUI-Update.json and SHA256SUMS.txt for the skins -- are all published by this fork's own release jobs, so pointing at this repository is what makes the update paths coherent rather than merely differently wrong. Left alone deliberately: the item lookup User-Agent still cites the upstream project, which is where the software comes from and is not an update path, and the updater tests keep their upstream fixture URLs because both updaters validate the download host rather than the repository, so the fixtures stay valid and stay mergeable with upstream. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both updaters that arrived with upstream itsspin#72 queried
itsspin/spinips, and electron-builder's publish target named it too. A build of this fork asked upstream what the newest release was.What each updater does, and why this matters differently for each
portable-updater.tsLoremaster.exeand swaps it via a PowerShell wrapperLoremaster.exe,SHA256SUMS.txtspinui-updater.tsSpinUI-UI.zip,SpinUI-Update.json,SHA256SUMS.txtThe skin updater is the one that runs on Linux, so it was the live problem.
Why this fork is a coherent target
Every asset both updaters want is already published by this fork's own release jobs —
Loremaster.exefrom the Windows job,SpinUI-UI.zipandSpinUI-Update.jsonfrom the UI job, withSHA256SUMS.txtalongside. So this is not swapping one broken target for another.Left alone deliberately
item-intelligence.tsstill cites the upstream project. It identifies where the software comes from and is not an update path.OFFICIAL_DOWNLOAD_HOSTS) rather than the repository, so the fixtures remain valid — and unchanged fixtures stay mergeable with upstream.Bearing on RC releases
Both updaters skip
draftandprereleasereleases (portable-updater.ts:256,spinui-updater.ts:442). With this change they skip this fork's prereleases, so an RC published here is installable by hand and never auto-offered.Worth knowing for RC testing: the app self-update path is Windows-only — it looks for a portable
.exe. A Linux AppImage has no self-update at all, so an RC AppImage is inherently a manual install, and the skin updater running beside it will still see only full releases.Verification
ALL PASS(run underTZ=UTC, as CI does)tsc --noEmit(renderer): clean🤖 Generated with Claude Code