Skip to content

#109 initial batch mode - #221

Merged
jamesmarkchan merged 4 commits into
devfrom
feature/batch-mode
Sep 8, 2026
Merged

#109 initial batch mode#221
jamesmarkchan merged 4 commits into
devfrom
feature/batch-mode

Conversation

@jamesmarkchan

@jamesmarkchan jamesmarkchan commented Sep 7, 2026

Copy link
Copy Markdown
Member

new batch mode feature:

  1. adding the batch benchmark mode to make it easier to run a suite of benchmarks against a selection of drives.
  2. user selects the drives and profiles to run against them.
  3. running view shows progress
  4. results view shows comparisons between drives
  5. history tab in the batch mode allow reviewing previous batch results.

selection view:

image

results examples:

image image

the running view:

image

report

image

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Batch cancellation is currently reported as “completed” (misleading UI/state), and a couple of smaller correctness/clarity issues should be addressed before merge.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds an initial “Batch mode” workflow to run selected benchmark profiles across multiple drives, track progress, and review historical batch runs via a new bottom-pane reports tab.

Changes:

  • Introduces Batch UI (setup → running → results) plus Batch Reports history tab and tab constants.
  • Persists batch grouping via a batchId on Benchmark and adds queries to load batch history.
  • Wires theme/palette updates so the batch comparison chart matches the active UI theme.
File summaries
File Description
RELEASE.md Adds release checklist documentation.
jdm-core/src/main/java/org/metricus/jdm/ui/Tabs.java Adds tab labels for Batch + Batch Reports.
jdm-core/src/main/java/org/metricus/jdm/ui/Palette.java Refreshes batch chart colors on palette apply.
jdm-core/src/main/java/jdiskmark/MainFrame.java Adds Batch top tab + Batch Reports bottom tab; refreshes reports on tab selection.
jdm-core/src/main/java/jdiskmark/Gui.java Stores references to new batch panels; refreshes chart on theme apply.
jdm-core/src/main/java/jdiskmark/Benchmark.java Adds batchId column and queries for batch history.
jdm-core/src/main/java/jdiskmark/BatchWorker.java Implements batch execution, retry, cooldown, persistence, and event publishing.
jdm-core/src/main/java/jdiskmark/BatchResult.java Adds in-memory representation of a batch run and per-run statuses.
jdm-core/src/main/java/jdiskmark/BatchReportsPanel.java Bottom-pane history table that loads selected batch into Batch tab.
jdm-core/src/main/java/jdiskmark/BatchPanel.java Full Batch tab UI: selection, progress, results chart/table, and history loading.
jdm-core/src/main/java/jdiskmark/BatchEvent.java Defines events used to drive the running UI.
jdm-core/src/main/java/jdiskmark/BatchConfig.java Captures batch selections and applies them to App for each run.
jdm-core/src/main/java/jdiskmark/App.java Prevents starting a single benchmark while a batch is running.
jdm-core/docs/design.md Updates GUI tab design documentation to include Batch mode.
Review details
  • Files reviewed: 14/14 changed files
  • Comments generated: 4
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread jdm-core/src/main/java/jdiskmark/BatchWorker.java Outdated
Comment thread jdm-core/src/main/java/jdiskmark/BatchWorker.java Outdated
Comment thread RELEASE.md Outdated
Comment thread jdm-core/src/main/java/jdiskmark/BatchEvent.java Outdated
@jamesmarkchan

Copy link
Copy Markdown
Member Author

making the start button height consistent in the batch mode.

image

@jamesmarkchan
jamesmarkchan merged commit e7a2a1b into dev Sep 8, 2026
8 checks passed
@jamesmarkchan
jamesmarkchan deleted the feature/batch-mode branch September 8, 2026 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants