python: make StringProp to decode SPDX alias with actual ID#34
Closed
hongxu-jia wants to merge 1 commit into
Closed
python: make StringProp to decode SPDX alias with actual ID#34hongxu-jia wants to merge 1 commit into
hongxu-jia wants to merge 1 commit into
Conversation
This commit make StringProp to decode string as IRI first in which replace SPDX alias with actual ID. For other situation, still return string as usual Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
JPEWdev
force-pushed
the
main
branch
2 times, most recently
from
044f11f to
5fadc0d
Compare
Owner
|
We can't fix this here, unfortunately. It would not be correct to assume that the value in a dictionary was an IRI and attempt to de reference it an object. Instead, a fix is needed in the SPDX 3 spec to make the mapping map the string keys to Elements instead strings, spdx/spdx-3-model#969 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit make StringProp to decode string as IRI first in which replace SPDX alias with actual ID. For other situation, still return string as usual