Feature: translate C-Buttons as Smash/Aerial Attacks#66
Merged
JRickey merged 1 commit intoJRickey:mainfrom May 2, 2026
Merged
Conversation
5 tasks
JRickey
added a commit
that referenced
this pull request
May 2, 2026
Feature: translate C-Buttons as Smash/Aerial Attacks (rebased from #66)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the player to set the C buttons to smash attacks, or aerial attacks if the player is in the air, as opposed to the default jump behavior. Makes it more akin to the later Smash games where the user can easily tilt the right stick to perform a smash attack.
A check is made to make sure this is only applied while the player is in the game; this ensures that the player can still adjust the character's color palette in the CSS with the C buttons without causing erratic behavior (i.e. the cursor snapping in a certain direction and hitting the A button at the same time).
If the user has tap jump disabled, this can be a problem though since they won't have any way to jump otherwise. As a compromise, I added a second toggle underneath that converts D-pad input to the C buttons. This way the player can map a button, such as X or Y on a Xbox-style gamepad, to any of the D-pad directions, and give them their jumping ability back.
Note there are some weird edge cases I've tested where, for example, the character will still jump as opposed to performing a smash attack, depending on how the stick was tilted, or the character will do a forward air attack when tilting down on the right stick immediately after jumping.
Also took the opportunity to re-organize the enhancement options in the menu a bit.