Feature: translate C-Buttons as Smash/Aerial Attacks (rebased from #66)

[JRickey]

Replaces #66 (which had merge conflicts against current main).

All commits from the original PR are preserved with their original authorship; this branch adds the merge of latest main + a small polish pass with conflict resolutions and minor code-quality cleanups, all credited to @the-outcaster as Co-Authored-By.

Summary (from #66)

Allows the player to set the C buttons to smash attacks, or aerial attacks if the player is in the air, as opposed to the default jump behavior. Makes it more akin to the later Smash games where the user can easily tilt the right stick to perform a smash attack.

A check is made to make sure this is only applied while the player is in the game; this ensures that the player can still adjust the character's color palette in the CSS with the C buttons without causing erratic behavior (i.e. the cursor snapping in a certain direction and hitting the A button at the same time).

If the user has tap jump disabled, this can be a problem though since they won't have any way to jump otherwise. As a compromise, I added a second toggle underneath that converts D-pad input to the C buttons. This way the player can map a button, such as X or Y on a Xbox-style gamepad, to any of the D-pad directions, and give them their jumping ability back.

What changed during merge resolution

• port/enhancements/enhancements.h / enhancements.cpp — both branches added new declarations and constants. Kept main's flat (no-indent) namespace style throughout. PR Feature: translate C-Buttons as Smash/Aerial Attacks #66 had two anonymous namespaces; folded into one alongside the existing block.
• port/gui/PortMenu.cpp — placeholder // hitbox comment in PR Feature: translate C-Buttons as Smash/Aerial Attacks #66 sat where main inserted the StageClearFrozenWallpaper widget; took main's widget verbatim.
• libultraship pinned at 833528a6 (post-Fix #82: stop rumble on shutdown so it doesn't outlive the process on Linux #87, includes StopAllRumble).

Polish on top

• Dedented the new per-port enhancement widget block from 8 → 4 spaces to match the surrounding function body.
• Added tooltips to P2/P3/P4 widgets matching the original code's commented-out style.
• Renamed helper parameter raw_tap → tap_pre_remap and documented why it's needed (snapshot of *button_tap taken BEFORE the helper rewrites it, used to detect rising-edge taps after C-bits get cleared).
• Added explicit i < GMCOMMON_PLAYERS_MAX bound in controller.c before indexing BattleState->players[] — the loop math equals PLAYERS_MAX today but the indirection is fragile and a per-player-array overrun has the same fingerprint as past LP64 per-gkind-table bugs.

Test plan

• Clean Release build (191/191 TUs)
• Binary launches; menu shows the new "Per-Port Enhancements" block with all four players
• In-game smoke test: C-Stick Smash (P1) on, C-button presses produce smash attacks
• CSS palette cycling with C-buttons still works when C-Stick Smash is on (the gameplay-only guard)
• D-Pad to Jump (P1) on while Disable Tap Jump (P1) is on → D-Pad direction triggers a jump

🤖 Generated with Claude Code