feat(review): skip ignored auto-review authors#3454
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Caution 🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥 🛑 Gittensory review result - reject/close recommendedReview updated: 2026-07-05 07:43:57 UTC
🛑 Suggested Action - Reject/Close
Review summary Blockers
Nits — 6 non-blocking
Why this is blocked
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
|
Gittensory is closing this pull request on the maintainer's behalf (AI reviewers agree on a likely critical defect: src/queue/processors.ts:7048 evaluates `review.auto_review.ignore_authors` before the existing no-visible-surface skip, so a repo with public/check output disabled and a matching ignored author records `ignored_author` instead of the preview/API's `surface_off`; move the ignored-author block after the existing `!gateEnabled && !autonomyNeedsGateEvaluation ...` surface-off branch, matching `src/signals/settings-preview.ts:86` where `hasVisiblePrSurface` is checked first.). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
Summary
review.auto_review.ignore_authorsso maintainers can skip AI/public review output for matching author login globs.Fixes #2060
Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires >=99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
npm run test:coverageexceeded the local 5-minute command window; focused changed-area coverage ran but failed the global threshold because it intentionally scoped included source files.npm run test:mcp-packis blocked locally on Windows becausescripts/check-mcp-package.mjsusesspawnSync("npm", ...), which returnsENOENTinstead of resolvingnpm.cmdin this shell.npm run ui:lintwas not run because this PR does not change UI source;ui:openapi:check,ui:typecheck, andui:buildpassed after regenerating the OpenAPI artifact.Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
Notes
npm run ui:openapi.