Skip to content

fix(signals): classify HTML source maps as generated#3458

Closed
jimcody1995 wants to merge 1 commit into
JSONbored:mainfrom
jimcody1995:fix/path-matchers-html-sourcemaps
Closed

fix(signals): classify HTML source maps as generated#3458
jimcody1995 wants to merge 1 commit into
JSONbored:mainfrom
jimcody1995:fix/path-matchers-html-sourcemaps

Conversation

@jimcody1995

Copy link
Copy Markdown
Contributor

Summary

Scope

  • Conventional Commit title format.
  • Focused — path-matchers + unit tests only.
  • Follows CONTRIBUTING.md.
  • No linked issue needed.

Validation

  • git diff --check
  • npm run test:ci on Node 22
  • npm audit --audit-level=moderate — 0 vulnerabilities
  • Unit test covers dist/index.html.map as generated via isGeneratedFile

Safety

  • No secrets, auth, or UI changes.
  • N/A for UI Evidence.

UI Evidence

N/A — backend path classifier only.

Notes

Conflict avoidance: Touches only src/signals/path-matchers.ts and test/unit/path-matchers.test.ts. Zero overlap with open PRs (#3457 enrichment, #3456 orb relay, #3455/#3304 queue, #3454 review-eligibility, #3452 focus-manifest tests, #3451 engine, #3443 selfhost, #3433 integrations, #3414 review-evasion, #3314 miner, #3305 enrichment-wire). Merges cleanly after any of those land without rebase.

Made with Cursor

HTML bundlers emit .html.map siblings; slop already treated .vue.map
and .mdx.map as generated but missed .html.map, so machine output was
miscounted as substantive source in classifyChangedFile.

Co-authored-by: Cursor <cursoragent@cursor.com>
@jimcody1995 jimcody1995 requested a review from JSONbored as a code owner July 5, 2026 07:48
@superagent-security

Copy link
Copy Markdown

Superagent didn't find any vulnerabilities or security issues in this PR.

@gittensory-orb gittensory-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.5x multiplier. label Jul 5, 2026
@gittensory-orb

gittensory-orb Bot commented Jul 5, 2026

Copy link
Copy Markdown

Caution

🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥

🛑 Gittensory review result - reject/close recommended

Review updated: 2026-07-05 07:52:47 UTC

2 files · 1 AI reviewer · 2 blockers · readiness 80/100 · CI green · clean

🛑 Suggested Action - Reject/Close

  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
  • Maintainer requires a linked issue — Link the relevant issue (for example Closes #123) before opening the PR.

Review summary
The change correctly extends the generated-file source-map matcher so `*.html.map` follows the same path as existing front-end source-map siblings, and the unit test drives the production `isGeneratedFile` path directly. The implementation is narrow, case-insensitive through existing normalization, and does not disturb category precedence in `classifyChangedFile`. I do not see a reachable correctness defect in the visible diff.

Nits — 4 non-blocking
  • nit: `src/signals/path-matchers.ts:63` still describes this regex as "every first-class JS/TS bundle extension" even though it already includes CSS/framework extensions and now HTML, so the comment should be broadened to match the actual matcher.
  • Update `src/signals/path-matchers.ts:63` to say this covers first-class front-end bundle/source-map extensions, not only JS/TS.
  • If this PR is from an external contributor, link the maintainer-authorized issue explicitly instead of saying "No linked issue needed" in the PR description.
  • Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.

Why this is blocked

  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
  • Maintainer requires a linked issue — Link the relevant issue (for example Closes #123) before opening the PR.
Signal Result Evidence
Code review ❌ 2 blockers 1 reviewer
Linked issue ✅ No-issue rationale PR body explains why no issue is linked.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 58 registered-repo PR(s), 31 merged, 0 issue(s).
Contributor context ✅ Confirmed Gittensor contributor jimcody1995; Gittensor profile; 58 PR(s), 0 issue(s).
Gate result ❌ Blocking Repo-configured hard blocker found.
Review context
  • Author: jimcody1995
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 58 PR(s), 0 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.99%. Comparing base (1dcc412) to head (2d7f6f5).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3458   +/-   ##
=======================================
  Coverage   92.99%   92.99%           
=======================================
  Files         296      296           
  Lines       30972    30972           
  Branches    11294    11294           
=======================================
  Hits        28803    28803           
  Misses       1514     1514           
  Partials      655      655           
Files with missing lines Coverage Δ
src/signals/path-matchers.ts 88.46% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gittensory-orb

gittensory-orb Bot commented Jul 5, 2026

Copy link
Copy Markdown

Gittensory is closing this pull request on the maintainer's behalf (No linked issue detected; Maintainer requires a linked issue). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed.

@gittensory-orb gittensory-orb Bot closed this Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.5x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant