fix(signals): classify HTML source maps as generated#3458
Conversation
HTML bundlers emit .html.map siblings; slop already treated .vue.map and .mdx.map as generated but missed .html.map, so machine output was miscounted as substantive source in classifyChangedFile. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Caution 🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥 🛑 Gittensory review result - reject/close recommendedReview updated: 2026-07-05 07:52:47 UTC
🛑 Suggested Action - Reject/Close
Review summary Nits — 4 non-blocking
Why this is blocked
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3458 +/- ##
=======================================
Coverage 92.99% 92.99%
=======================================
Files 296 296
Lines 30972 30972
Branches 11294 11294
=======================================
Hits 28803 28803
Misses 1514 1514
Partials 655 655
🚀 New features to boost your workflow:
|
|
Gittensory is closing this pull request on the maintainer's behalf (No linked issue detected; Maintainer requires a linked issue). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
Summary
isGeneratedFileinpath-matchers.tsto treat.html.mapas generated output, matching the existing.vue.map/.mdx.map/.sass.maphandling (fix(signals): classify vue/svelte/astro source maps as generated #3357, fix(signals): classify MDX source maps as generated #3446, fix(signals): classify Sass source maps as generated #3453).review/visual/paths.ts; bundler source-map siblings were still miscounted as substantive source.Scope
CONTRIBUTING.md.Validation
git diff --checknpm run test:cion Node 22npm audit --audit-level=moderate— 0 vulnerabilitiesdist/index.html.mapas generated viaisGeneratedFileSafety
UI Evidence
N/A — backend path classifier only.
Notes
Conflict avoidance: Touches only
src/signals/path-matchers.tsandtest/unit/path-matchers.test.ts. Zero overlap with open PRs (#3457 enrichment, #3456 orb relay, #3455/#3304 queue, #3454 review-eligibility, #3452 focus-manifest tests, #3451 engine, #3443 selfhost, #3433 integrations, #3414 review-evasion, #3314 miner, #3305 enrichment-wire). Merges cleanly after any of those land without rebase.Made with Cursor