Skip to content

feat(review): dedupe identical inline findings across dual reviewers before rendering #2158

Description

@JSONbored

In dual/consensus review, the two models can emit the same line-anchored finding, producing duplicate inline comments (selectInlineComments only dedupes by path+line AFTER compose, dropping the second silently). Merge near-identical findings on the same line in composeInlineFindings, preferring the higher severity and keeping any suggestion/category — cleaner surface, fewer dropped notes.

Deliverables

  • In composeInlineFindings (src/services/ai-review.ts:841) merge findings with the same (path,line): keep the max severity, prefer a present suggestion/category
  • Preserve the existing per-line ordering + cap semantics
  • Do not change gate behavior (compose is advisory-only)
  • Tests: two models same line different severity → merged max, distinct lines untouched, suggestion carried from whichever model had it (all branches)

References

  • src/services/ai-review.ts:841
  • src/review/inline-comments.ts:79
  • part of #1956

Part of #1956.


size: S · held for later release (gittensor:feature once activated)

Metadata

Metadata

Assignees

No one assigned

    Labels

    gittensor:featureGittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions