Skip to content

AccordionTrigger has no focus-visible indicator, unlike every other interactive control in ui-kit #7015

Description

@JSONbored

Context

packages/loopover-ui-kit/src/components/accordion.tsx's AccordionTrigger (lines 20-33) has no focus indicator at all — its className only includes hover:underline for the hover state, with nothing for :focus-visible. Every other styled interactive trigger/control in this same component library applies a focus-visible:ring-* class: button.tsx:8, tabs.tsx:30, toggle.tsx:8, switch.tsx:12, checkbox.tsx:14, slider.tsx:18. A keyboard user tabbing to an accordion header today gets zero visible indication of where focus is.

Requirements

  • Add a focus-visible:ring-* class to AccordionTrigger's className, matching the exact ring styling (color, width, offset) already used by the sibling components listed above.
  • Do not change AccordionTrigger's hover/open-state styling or its ChevronDown rotation behavior — this issue is scoped to adding the missing focus-visible indicator only.

Deliverables

  • AccordionTrigger has a visible focus-visible:ring-* state matching the kit's existing convention
  • Test or story confirming the focus-visible class is present (a Storybook/visual-regression check if this kit has one, otherwise a rendered-className assertion)

Test Coverage Requirements

packages/loopover-ui-kit — check coverage.include for this package; if covered, 99%+ Codecov patch coverage plus a before/after screenshot of the focus state per this repo's UI-PR convention.

Expected Outcome

Keyboard users tabbing through an accordion get the same visible focus indication every other interactive control in the kit already provides.

Links & Resources

packages/loopover-ui-kit/src/components/button.tsx:8, tabs.tsx:30, toggle.tsx:8, switch.tsx:12, checkbox.tsx:14, slider.tsx:18 — the existing focus-visible:ring-* convention to match. packages/loopover-ui-kit/src/components/accordion.tsx:20-33 — the component to fix.

Metadata

Metadata

Assignees

No one assigned

    Labels

    gittensor:bugGittensor-scored bug fix — scores a 0.05x multiplier.help wantedExtra attention is needed

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions