Summary
Tracking epic for approval-queue and review-lifecycle defects from the 2026-07-27 adversarial audit. The common thread: states a PR can enter and never leave, plus a replay path that enforces fewer protections than the live path.
Sub-issues
| Issue |
Class |
| #9481 — expired approvals can never be re-staged |
Absorbing state |
| #9482 — accept path's thinner context voids three shipped protections |
Wrong merge / lost enforcement |
| #9483 — merge-train waiter stranded; verdict-flip guard absorbing |
Silent stranding |
Also related and filed elsewhere: #9465 (a dead reopen-reclose job permanently loses one-shot enforcement) and #9464 (a false-close path).
Cross-cutting recommendation
#9482's root cause is that both the live path and the accept path build an executor context out of optional fields, so an omission is silent rather than a type error. The durable fix — a single typed "decision pass context" that both paths must construct — also closes part of the determinism gap tracked in the maintainability epic, where the same ad-hoc context is why the decision clock reaches only one of its consumers. Worth doing once, properly, rather than patching each omission.
Acceptance criteria
Summary
Tracking epic for approval-queue and review-lifecycle defects from the 2026-07-27 adversarial audit. The common thread: states a PR can enter and never leave, plus a replay path that enforces fewer protections than the live path.
Sub-issues
Also related and filed elsewhere: #9465 (a dead
reopen-reclosejob permanently loses one-shot enforcement) and #9464 (a false-close path).Cross-cutting recommendation
#9482's root cause is that both the live path and the accept path build an executor context out of optional fields, so an omission is silent rather than a type error. The durable fix — a single typed "decision pass context" that both paths must construct — also closes part of the determinism gap tracked in the maintainability epic, where the same ad-hoc context is why the decision clock reaches only one of its consumers. Worth doing once, properly, rather than patching each omission.
Acceptance criteria