ci(fixture-clock-races): scan packages/loopover-engine/test too

[bitfathers94]

ci(fixture-clock-races): scan packages/loopover-engine/test too

The checker's main() only ever walked test/, so the same helper-re-reads-
the-clock shape it exists to catch could still land in the engine
package's independently-run suite and auto-close a correct PR on timing
alone. Widen the scan to a named FIXTURE_TEST_ROOTS list (mirroring
check-dead-exports.ts's REFERENCE_ROOTS pattern) and fix the one
violation that was already sitting there.

Closes #10043

[loopover-orb]

Tip

✅ LoopOver review result - approve/merge recommended

_{Review updated: 2026-07-31 08:50:23 UTC}

3 files · 1 AI reviewer · no blockers · readiness 98/100 · CI green · clean

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
This PR widens the fixture-clock-race checker from a hardcoded `test/` walk to a `FIXTURE_TEST_ROOTS` list that also covers `packages/loopover-engine/test`, extracts `walk()` as exported/tolerant-of-missing-dirs, and fixes the one real violation (`daysAgoIso` in issue-quality-report.test.ts) by anchoring it to a captured `FIXTURE_NOW_MS`. The change is correct and well-tested: the new regression test reproduces the exact pre-fix helper shape, and separate tests exercise `walk()`'s missing-directory tolerance and multi-root reach. This closes #10043 directly and mirrors the existing `REFERENCE_ROOTS`-style pattern from check-turbo-typecheck-inputs.ts, keeping the codebase's checker conventions consistent.

Nits — 3 non-blocking

• scripts/check-fixture-clock-races.ts: `walk` exclusion list only skips `node_modules`, so if `packages/loopover-engine` ever gains a `dist/test` fixture directory containing generated `.test.ts` files it would be swept in too — worth a comment or filter if that becomes a real pattern, but not currently a live risk.
• test/unit/check-fixture-clock-races-script.test.ts: the new `FIXTURE_TEST_ROOTS` describe block duplicates some setup/teardown boilerplate (mkdtemp/rmSync) that could be shared via a helper if more root-list tests get added later.
• Consider deriving `FIXTURE_TEST_ROOTS` dynamically (e.g. scanning for `packages/*/test` dirs) the way `coveredWorkspacesFromDependsOn` in check-turbo-typecheck-inputs.ts derives workspace coverage, so a future third package's test dir doesn't require another manual addition to this list — not blocking since the current two-entry list is accurate today.

Decision drivers

• ✅ Code review — No blockers (1 reviewer)
• ✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#10043
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 98 registered-repo PR(s), 67 merged, 3 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	bitfathers94; Gittensor profile; 98 PR(s), 3 issue(s).
Improvement	✅ Minor	risk: clean · value: minor · LLM: moderate

Linked issue satisfaction

Addressed
The diff adds an exported FIXTURE_TEST_ROOTS constant covering both test/ and packages/loopover-engine/test, updates main() to loop over it while preserving root-relative path slicing and walk's missing-directory tolerance, fixes issue-quality-report.test.ts to derive daysAgoIso from a single FIXTURE_NOW_MS, and adds the required regression tests asserting the roots list and the exact daysAgoIso r

Review context

• Author: bitfathers94
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: TypeScript
• Official Gittensor activity: 98 PR(s), 3 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Keep the PR focused and include validation evidence before maintainer review.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.96%. Comparing base (117f750) to head (8b4a418).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #10130   +/-   ##
=======================================
  Coverage   91.96%   91.96%           
=======================================
  Files         931      931           
  Lines      113975   113975           
  Branches    27519    27519           
=======================================
  Hits       104817   104817           
  Misses       7858     7858           
  Partials     1300     1300           

Flag	Coverage Δ
backend	95.67% <ø> (ø)
engine	72.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[loopover-orb]

LoopOver approves — the gate is satisfied and CI is green.