fix(mcp): advertise _meta.category on all three servers - #10162
Conversation
registerStdioTool and registerMinerTool were the only two tool-registration
wrappers that never attached _meta, so the stdio server's locally-registered
tools and the miner's entire surface carried no category on the wire even
though the contract's projection has always had one. Both now spread
_meta: { category } from the same projected definition they already use for
title/description/annotations.
checkAdvertisedMetadata gains the matching branch so a server that stops
sending it fails validate:mcp instead of drifting silently again.
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-31 10:42:54 UTC
Review summary Nits — 4 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10162 +/- ##
=======================================
Coverage 92.21% 92.21%
=======================================
Files 931 931
Lines 114066 114066
Branches 27546 27546
=======================================
Hits 105183 105183
Misses 7584 7584
Partials 1299 1299
Flags with carried forward coverage won't be shown. Click here to find out more.
|
fix(mcp): advertise _meta.category on all three servers
registerStdioTool and registerMinerTool were the only two tool-registration
wrappers that never attached _meta, so the stdio server's locally-registered
tools and the miner's entire surface carried no category on the wire even
though the contract's projection has always had one. Both now spread
_meta: { category } from the same projected definition they already use for
title/description/annotations.
checkAdvertisedMetadata gains the matching branch so a server that stops
sending it fails validate:mcp instead of drifting silently again.
Closes #10038