Skip to content

chore(ci): remove redundant type-label GHA (review applies the label) - #1088

Merged
JSONbored merged 1 commit into
mainfrom
chore/remove-type-label-gha
Jun 23, 2026
Merged

chore(ci): remove redundant type-label GHA (review applies the label)#1088
JSONbored merged 1 commit into
mainfrom
chore/remove-type-label-gha

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

The type-label.yml GHA duplicated the Gittensory review's own type-labeling (gittensor:bug/feature/priority via resolvePrTypeLabel during review; auto_label enabled on all repos). Consolidating into the review removes a redundant CI step. Removed the orphaned scripts/github-type-label.mjs + its test; the bot's labeling keeps coverage in pr-type-label.test.ts. Issue type-labels intentionally dropped. 3422 tests pass.

…applies the type label

type-label.yml (Apply Gittensor reward label) duplicated what the Gittensory review already does during the review: gittensory:bug/feature/priority via resolvePrTypeLabel + ensurePullRequestLabel (auto_label_enabled on all repos). Consolidating labeling into the review removes a redundant CI step. The bot's labeling keeps its own coverage (pr-type-label.test.ts); removed the orphaned script + its test. Issue type-labeling is intentionally dropped per the operator.
@dosubot dosubot Bot added the size:L label Jun 23, 2026
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.76%. Comparing base (13522b8) to head (20fac29).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1088   +/-   ##
=======================================
  Coverage   94.76%   94.76%           
=======================================
  Files         153      153           
  Lines       18542    18542           
  Branches     6711     6711           
=======================================
  Hits        17572    17572           
  Misses        418      418           
  Partials      552      552           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ghost

ghost commented Jun 23, 2026

Copy link
Copy Markdown

Tip

🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

✅ Gittensory review — safe to merge

3 files · 2 AI reviewers · no blockers · readiness 100/100 · CI green · unstable

✅ Approved — safe to merge

Review summary
The pull request removes the `type-label.yml` GitHub Actions workflow, the `scripts/github-type-label.mjs` script, and its associated test suite. The change is straightforward: it deletes files that were previously used solely for automatically applying Gittensor type labels, a responsibility now handled by the review bot. No new code is introduced, and the diff does not modify any existing functionality. Assuming no other parts of the repository import or depend on the removed script or workflow, the change should be safe and will reduce CI runtime by eliminating a redundant step.

Suggestions

  • Search the entire codebase for any imports or references to `scripts/github-type-label.mjs` (e.g., in package.json scripts, other CI workflows, or documentation) and remove or update them to avoid broken imports.
  • Verify that the CI configuration (e.g., any reusable workflow calls or matrix definitions) does not expect the `type-label.yml` file to exist; if it does, adjust those configurations accordingly.
  • Update the repository README or contribution guidelines to note that type labeling is now performed by the review bot and that the old workflow has been removed.
  • If the test coverage thresholds were calibrated to include `github-type-label.test.ts`, ensure the coverage configuration accounts for its removal so that CI does not fail due to reduced coverage.
  • Consider adding a deprecation note in the commit history or a changelog entry indicating the removal of the type‑label automation.

Risks

  • If any other workflow, script, or external tool still references `scripts/github-type-label.mjs` or the `type-label.yml` workflow, the repository will fail to build or the CI will error due to missing files.
  • Removing the test file may cause coverage metrics to drop below the project's required thresholds if the CI enforces a minimum coverage percentage.
  • Documentation or onboarding material that mentions the old type‑label workflow may become outdated, leading to confusion for new contributors.
  • There is a potential risk if the review process or auto_label feature does not cover all the event types previously handled by the removed workflow (specifically, issue events: opened, edited, reopened). However, the description states that the review process duplicates the workflow's labeling and that auto_label is enabled, suggesting coverage is maintained.
Signal Result Evidence
Code review ✅ No blockers 2 reviewers, synthesized
Linked issue ✅ No-issue rationale PR body explains why no issue is linked.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Review load ✅ 20/20 Readiness component derived from cached public PR metadata and labels; size label size:L.
Validation evidence ✅ 25/25 PR body includes validation/test evidence.
Open PR queue ✅ 10/10 0 open PR(s), 0 likely reviewable.
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 84 PR(s), 254 issue(s).
Gate result ✅ Passing No configured blocker found.
Nits — 1 non-blocking
  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Python, TypeScript, JavaScript, Ruby, Go, Kotlin, MDX, Shell
  • Official Gittensor activity: 84 PR(s), 254 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Treat this as maintainer-lane context rather than normal contributor-lane activity.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Review load = cached public PR metadata such as size labels, changed paths, and preflight status.
  • Open PR queue = repo-wide review pressure; it is not a PR quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
Review details

Generated from public PR metadata and the diff. Advisory only; deterministic signals remain authoritative.

The pull request removes the `type-label.yml` GitHub Actions workflow, the `scripts/github-type-label.mjs` script, and its associated test suite. The change is straightforward: it deletes files that were previously used solely for automatically applying Gittensor type labels, a responsibility now handled by the review bot. No new code is introduced, and the diff does not modify any existing functionality. Assuming no other parts of the repository import or depend on the removed script or workflow, the change should be safe and will reduce CI runtime by eliminating a redundant step.

Suggestions

  • Search the entire codebase for any imports or references to `scripts/github-type-label.mjs` (e.g., in package.json scripts, other CI workflows, or documentation) and remove or update them to avoid broken imports.
  • Verify that the CI configuration (e.g., any reusable workflow calls or matrix definitions) does not expect the `type-label.yml` file to exist; if it does, adjust those configurations accordingly.
  • Update the repository README or contribution guidelines to note that type labeling is now performed by the review bot and that the old workflow has been removed.
  • If the test coverage thresholds were calibrated to include `github-type-label.test.ts`, ensure the coverage configuration accounts for its removal so that CI does not fail due to reduced coverage.
  • Consider adding a deprecation note in the commit history or a changelog entry indicating the removal of the type‑label automation.

Risks

  • If any other workflow, script, or external tool still references `scripts/github-type-label.mjs` or the `type-label.yml` workflow, the repository will fail to build or the CI will error due to missing files.
  • Removing the test file may cause coverage metrics to drop below the project's required thresholds if the CI enforces a minimum coverage percentage.
  • Documentation or onboarding material that mentions the old type‑label workflow may become outdated, leading to confusion for new contributors.
  • There is a potential risk if the review process or auto_label feature does not cover all the event types previously handled by the removed workflow (specifically, issue events: opened, edited, reopened). However, the description states that the review process duplicates the workflow's labeling and that auto_label is enabled, suggesting coverage is maintained.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@ghost ghost added gittensory:reviewed gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. labels Jun 23, 2026

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied and CI is green.

@JSONbored
JSONbored merged commit 01c315b into main Jun 23, 2026
19 checks passed
@JSONbored
JSONbored deleted the chore/remove-type-label-gha branch June 23, 2026 17:13
loopover-orb Bot pushed a commit that referenced this pull request Jul 20, 2026
The github-type-label.mjs implementation (plus its workflow and test) was deleted in
#1088 (commit 01c315b) when type-labeling was consolidated into the review's own
resolvePrTypeLabel/ensurePullRequestLabel path, but its hand-written .d.mts type
declaration was left behind. It is the only .d.mts under scripts/ without a matching
.mjs implementation, and a repo-wide search for 'github-type-label' finds no remaining
references. Remove the orphan.

Closes #7434
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant