chore(ci): remove redundant type-label GHA (review applies the label) - #1088
Conversation
…applies the type label type-label.yml (Apply Gittensor reward label) duplicated what the Gittensory review already does during the review: gittensory:bug/feature/priority via resolvePrTypeLabel + ensurePullRequestLabel (auto_label_enabled on all repos). Consolidating labeling into the review removes a redundant CI step. The bot's labeling keeps its own coverage (pr-type-label.test.ts); removed the orphaned script + its test. Issue type-labeling is intentionally dropped per the operator.
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1088 +/- ##
=======================================
Coverage 94.76% 94.76%
=======================================
Files 153 153
Lines 18542 18542
Branches 6711 6711
=======================================
Hits 17572 17572
Misses 418 418
Partials 552 552 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ Gittensory review — safe to merge
✅ Approved — safe to merge Review summary Suggestions
Risks
Nits — 1 non-blocking
Review context
Contributor next steps
Signal definitions
Review detailsGenerated from public PR metadata and the diff. Advisory only; deterministic signals remain authoritative. The pull request removes the `type-label.yml` GitHub Actions workflow, the `scripts/github-type-label.mjs` script, and its associated test suite. The change is straightforward: it deletes files that were previously used solely for automatically applying Gittensor type labels, a responsibility now handled by the review bot. No new code is introduced, and the diff does not modify any existing functionality. Assuming no other parts of the repository import or depend on the removed script or workflow, the change should be safe and will reduce CI runtime by eliminating a redundant step. Suggestions
Risks
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
ghost
left a comment
There was a problem hiding this comment.
Gittensory approves — the gate is satisfied and CI is green.
The github-type-label.mjs implementation (plus its workflow and test) was deleted in #1088 (commit 01c315b) when type-labeling was consolidated into the review's own resolvePrTypeLabel/ensurePullRequestLabel path, but its hand-written .d.mts type declaration was left behind. It is the only .d.mts under scripts/ without a matching .mjs implementation, and a repo-wide search for 'github-type-label' finds no remaining references. Remove the orphan. Closes #7434
The
type-label.ymlGHA duplicated the Gittensory review's own type-labeling (gittensor:bug/feature/priorityvia resolvePrTypeLabel during review; auto_label enabled on all repos). Consolidating into the review removes a redundant CI step. Removed the orphanedscripts/github-type-label.mjs+ its test; the bot's labeling keeps coverage inpr-type-label.test.ts. Issue type-labels intentionally dropped. 3422 tests pass.