feat(signals): redact /var/ paths on the public-safety boundary#1457
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1457 +/- ##
=======================================
Coverage 95.38% 95.38%
=======================================
Files 201 201
Lines 21598 21598
Branches 7807 7807
=======================================
Hits 20601 20601
Misses 416 416
Partials 581 581
🚀 New features to boost your workflow:
|
Extend the canonical PUBLIC_UNSAFE_PATTERN so /var/ local paths are blocked on public GitHub surfaces alongside /root/ and /tmp/. Co-authored-by: Cursor <cursoragent@cursor.com>
1ed8a39 to
1805afd
Compare
|
Caution 🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥 🛑 Gittensory review — closed
🛑 Closed — Readiness score is below the configured threshold — Address the short explicit PR panel actions, then re-run the gate. Review summary Why this is blocked
Nits — 3 non-blocking
Review context
Contributor next steps
Signal definitions
Review detailsGenerated from public PR metadata and the diff. Advisory only; deterministic signals remain authoritative. This change correctly extends the shared public-safety regex so absolute `/var/...` paths are rejected by `isPublicSafeText`, matching the existing treatment for other local filesystem roots. The test update covers both a common Linux service path and the macOS `/var/folders/...` shape, so the new branch is exercised directly. The change is small, localized, and consistent with the existing canonical boundary design. Nits (2)
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Summary
PUBLIC_UNSAFE_PATTERNinredaction.tsto treat/var/local paths as unsafe on public GitHub surfaces./root/was already redacted but macOS/Linux/var/folders/...and/var/log/...paths could leak throughisPublicSafeText.Related: #1307 (slice), #1418
Test plan
npx vitest run test/unit/redaction.test.ts/var/log/...and/var/folders/...are rejected