fix(blacklist): add shared/global contributor blacklist#1531
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1531 +/- ##
=======================================
Coverage 95.53% 95.54%
=======================================
Files 204 204
Lines 22282 22293 +11
Branches 8048 8052 +4
=======================================
+ Hits 21288 21299 +11
Misses 415 415
Partials 579 579
🚀 New features to boost your workflow:
|
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review — held for maintainer review
⏸️ Held for maintainer review — This is a first-time contribution to this repo, so the gate stays advisory rather than blocking. The findings remain visible, and the gate will apply normally once this author has merge history here. Review summary
Nits — 5 non-blocking
Review context
Contributor next steps
Signal definitions
Review detailsGenerated from public PR metadata and the diff. Advisory only; deterministic signals remain authoritative. This adds a migration-backed singleton table plus DB helpers for a shared contributor blacklist, then threads that list through repository settings resolution so the webhook and re-gate enforcement path merges it with per-repo manifest/DB settings before `findBlacklistEntry` is evaluated. The merge order is deliberate and covered: effective per-repo settings win metadata on duplicate logins while the shared list still contributes additional entries. I do not see a reachable correctness blocker in the provided diff; the notable remaining risks are observability around the fail-open read and the lack of an obvious operator write surface in this PR. Nits (5)
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
727ad5d to
c365d05
Compare
Main added 0075_ai_review_all_authors.sql (JSONbored#1555) before this PR landed, so the original 0075_global_contributor_blacklist.sql collides with it. The db:migrations:check step in the CI lint job fails on the duplicate. Rename to 0082 (next free number) so both migrations can coexist.
Summary
global_contributor_blacklistand DB read/write APIs..gittensory.yml/DB + shared/global list.Validation
npm run db:migrations:checknpm run typechecknpm test -- test/unit/contributor-blacklist.test.ts test/unit/focus-manifest.test.ts test/unit/selftune-readback.test.tsnpm run test:unitCloses #1425