test(github): cover ready_for_review webhook coalesce key - #2376
test(github): cover ready_for_review webhook coalesce key#2376bohdansolovie wants to merge 1 commit into
Conversation
ready_for_review is coalescable but was untested alongside opened/sync. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2376 +/- ##
=======================================
Coverage 95.71% 95.71%
=======================================
Files 222 222
Lines 24661 24661
Branches 8949 8949
=======================================
Hits 23605 23605
Misses 433 433
Partials 623 623 🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-02 04:19:53 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 3 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
JSONbored
left a comment
There was a problem hiding this comment.
Problems:
The most notable limitation is that the test uses a different PR/SHA than the opened case, so it proves the key format but not literal coalescing with an otherwise identical opened payload.
Closing.
Summary
ready_for_reviewpull_request webhooks coalesce to the samepr-refreshkey as opened/sync events.Test plan
npx vitest run test/unit/github-webhook-coalesce.test.ts