fix(review): redact duplicate surface summaries - #2475
Merged
Conversation
Contributor
|
Important 🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪 🔍 Gittensory is reviewing…AI analysis is in progress. This comment will update when the review is complete. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟪 Reviewing |
Owner
Author
|
False positive re: secret flag, merging. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 2d8a2d7 | Commit Preview URL Branch Preview URL |
Jul 02 2026, 05:42 AM |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2475 +/- ##
=======================================
Coverage 95.94% 95.95%
=======================================
Files 226 226
Lines 25361 25385 +24
Branches 9229 9233 +4
=======================================
+ Hits 24333 24357 +24
Misses 417 417
Partials 611 611
🚀 New features to boost your workflow:
|
The ghp_ + 36-char placeholder in the leaked-URL regression test matched GitHub's real personal-access-token shape and tripped the secret scanner on push, even though it was an all-A's fixture with no real credential.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
url) into public gate/finding text before the normal secret and URL validation steps run.urlcontent which could include PAT-like tokens, wallet/hotkey text, newlines, or Markdown.Description
urlso duplicate detection no longer echoes unvalidated content.duplicateEntryCloseSummary()insrc/review/content-lane/orchestrator.ts.test/unit/content-lane-orchestrator.test.tsto assert the generic close summary for same-PR and base-resubmission duplicates.url(PAT-like token + newline + Markdown) and asserts it is not reflected in the returned summary.Testing
git diff --checkwhich reported no whitespace/conflict issues.npx vitest run test/unit/content-lane-orchestrator.test.ts --reporter=dotand the test file passed (all tests in that file succeeded).npm run typecheckwhich succeeded.npm run test:coverage, which executed but failed the global coverage threshold (the project-level coverage requirement prevented the run from passing in this environment).Codex Task