Skip to content

fix(review): redact duplicate surface summaries - #2475

Merged
JSONbored merged 3 commits into
mainfrom
codex/fix-duplicate-url-exposure-vulnerability
Jul 2, 2026
Merged

fix(review): redact duplicate surface summaries#2475
JSONbored merged 3 commits into
mainfrom
codex/fix-duplicate-url-exposure-vulnerability

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Motivation

  • Prevent leaking unvalidated, attacker-controlled duplicate entry fields (notably url) into public gate/finding text before the normal secret and URL validation steps run.
  • Address the vulnerability where duplicate-detection returned a summary containing raw url content which could include PAT-like tokens, wallet/hotkey text, newlines, or Markdown.

Description

  • Replace the duplicate-entry close summary to be fully generic and remove interpolation of the duplicate entry's url so duplicate detection no longer echoes unvalidated content.
  • Stop passing the duplicate entry into the summary generator and instead return the stable generic message from duplicateEntryCloseSummary() in src/review/content-lane/orchestrator.ts.
  • Update unit tests in test/unit/content-lane-orchestrator.test.ts to assert the generic close summary for same-PR and base-resubmission duplicates.
  • Add a regression test that constructs an unsafe duplicate url (PAT-like token + newline + Markdown) and asserts it is not reflected in the returned summary.

Testing

  • Ran git diff --check which reported no whitespace/conflict issues.
  • Ran the targeted unit file with npx vitest run test/unit/content-lane-orchestrator.test.ts --reporter=dot and the test file passed (all tests in that file succeeded).
  • Ran typecheck via npm run typecheck which succeeded.
  • Attempted a repository-wide coverage run with npm run test:coverage, which executed but failed the global coverage threshold (the project-level coverage requirement prevented the run from passing in this environment).

Codex Task

@loopover-orb

loopover-orb Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Important

🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪

🔍 Gittensory is reviewing…

AI analysis is in progress. This comment will update when the review is complete.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟪 Reviewing

@loopover-orb loopover-orb Bot added gittensor gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. labels Jul 2, 2026
@JSONbored JSONbored self-assigned this Jul 2, 2026
@JSONbored

Copy link
Copy Markdown
Owner Author

False positive re: secret flag, merging.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 2, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
gittensory-ui 2d8a2d7 Commit Preview URL

Branch Preview URL
Jul 02 2026, 05:42 AM

@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.95%. Comparing base (4101ca6) to head (f11f5ae).
⚠️ Report is 39 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2475   +/-   ##
=======================================
  Coverage   95.94%   95.95%           
=======================================
  Files         226      226           
  Lines       25361    25385   +24     
  Branches     9229     9233    +4     
=======================================
+ Hits        24333    24357   +24     
  Misses        417      417           
  Partials      611      611           
Files with missing lines Coverage Δ
src/review/content-lane/orchestrator.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The ghp_ + 36-char placeholder in the leaked-URL regression test matched
GitHub's real personal-access-token shape and tripped the secret scanner
on push, even though it was an all-A's fixture with no real credential.
@JSONbored
JSONbored merged commit 85f0d98 into main Jul 2, 2026
8 checks passed
@JSONbored
JSONbored deleted the codex/fix-duplicate-url-exposure-vulnerability branch July 2, 2026 07:19
@github-project-automation github-project-automation Bot moved this from Todo to Done in gittensory - v1 roadmap Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant