fix(enrichment): treat uppercase action SHA pins as pinned

[bohdansolovie]

Summary

• Match GitHub commit refs case-insensitively in the actions-pin analyzer.
• Stop reporting uppercase 40-character SHA pins as mutable third-party workflow references.

Test plan

• npm run rees:test -- test/actions-pin.test.ts (coverage already on main from test(enrichment): cover actions-pin analyzer #2396; this PR is production-only to avoid test-file conflicts)

[superagent-security]

🚨 Contributor flagged. Click here for more info: Superagent Dashboard

[loopover-orb]

Caution

🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥

🛑 Gittensory review result - reject/close recommended

_{Review updated: 2026-07-02 05:44:32 UTC}

1 file · 1 AI reviewer · 1 blocker · readiness 66/100 · CI green · blocked

🛑 Suggested Action - Reject/Close

• Maintainer test expectations unmet — Add or update tests, or attach passing validation output that satisfies the maintainer's test expectations.

Review summary
This change is narrowly scoped to the actions-pin analyzer: `FULL_SHA` now matches 40-character hexadecimal refs case-insensitively, so uppercase or mixed-case SHA pins no longer get reported as mutable third-party workflow references. The surrounding scan path still only inspects added workflow lines, keeps official actions excluded, and continues to flag tags/branches, so the visible production logic is correct. The main remaining gap is that the diff does not add an explicit regression test for uppercase SHA refs.

Nits — 4 non-blocking

• review-enrichment/src/analyzers/actions-pin.ts:8: nit: add or keep a production-path regression test that feeds `scanWorkflowPins` a third-party `uses:` line pinned to an uppercase 40-character SHA and asserts no finding is emitted.
• test/actions-pin.test.ts: add a focused case for `owner/action@​ABCDEF...` alongside the existing pinned/unpinned cases so this policy does not regress silently.
• Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.
• Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.

Why this is blocked

• Maintainer test expectations unmet — Add or update tests, or attach passing validation output that satisfies the maintainer's test expectations.

Signal	Result	Evidence
Code review	❌ 1 blocker	1 reviewer
Linked issue	⚠️ Missing	No linked issue or no-issue rationale found.
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (size label size:XS; no linked issue context).
Validation posture	❌ 5/25	Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload	✅ 10/10	Author activity: 140 registered-repo PR(s), 68 merged, 11 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	bohdansolovie; Gittensor profile; 140 PR(s), 11 issue(s).
Gate result	❌ Blocking	Repo-configured hard blocker found.

Review context

• Author: bohdansolovie
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository registration is not available in the local Gittensory cache.
• Public profile languages: not available
• Official Gittensor activity: 140 PR(s), 11 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Explain no-issue PR.
• Await review-lane availability.
• Triage stale or unlinked PRs.
• Refresh registry data or choose a registered active repo.
• Link the issue being solved, or explicitly explain why this is a no-issue PR.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

• Re-run Gittensory review