fix(enrichment): treat uppercase action SHA pins as pinned#2492
fix(enrichment): treat uppercase action SHA pins as pinned#2492bohdansolovie wants to merge 2 commits into
Conversation
Match GitHub commit refs case-insensitively so uppercase 40-char pins are not reported as mutable third-party workflow references. Co-authored-by: Cursor <cursoragent@cursor.com>
|
🚨 Contributor flagged. Click here for more info: Superagent Dashboard |
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-02 06:21:35 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 7 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Cover uppercase and mixed-case 40-char refs in the PR diff so the case-insensitive FULL_SHA guard is tied to analyzer behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
JSONbored
left a comment
There was a problem hiding this comment.
Closing:
the test diff deletes several existing regression cases that covered line attribution, quoted `uses` syntax, `.yaml` workflow files, unchanged lines, missing patches, and positive findings through `scanActionPins`. The regex change itself is safe enough, but the test rewrite weakens coverage around behavior this analyzer still owns.
Summary
Why production-only
Regression coverage already lives on
maininreview-enrichment/test/actions-pin.test.ts(#2396). This PR changes only the analyzer so it does not collide with that test file.Test plan
npm run rees:test -- test/actions-pin.test.ts