docs(config): document 4 real gate knobs missing from .gittensory.yml.example#2594
Conversation
….example gate.size.mode, gate.dryRun, gate.selfAuthoredLinkedIssue, and gate.aiReview.closeConfidence are all fully parsed by parseGateConfig and applied by resolveEffectiveSettings -- real, working, enforced knobs -- but none appeared in .gittensory.yml.example's documented gate: block. Three of the four (size.mode, dryRun, aiReview.closeConfidence) are config-as-code only, with no DB column or dashboard equivalent; selfAuthoredLinkedIssue has a real DB column (self_authored_linked_issue_gate_mode) the yml value overrides. Added all 4 to the example file with the exact doc-comment convention already used for every other gate sub-field, noting config-as-code-only scope where applicable. Added a regression test that parses the actual .gittensory.yml.example file through the real parser and asserts zero warnings plus round-trips the 4 new knobs, so documentation can never silently drift from parser behavior again.
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ Gittensory review result - approve/merge recommendedReview updated: 2026-07-02 12:06:39 UTC
✅ Suggested Action - Approve/Merge
Review summary Nits — 3 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2594 +/- ##
==========================================
+ Coverage 95.98% 96.02% +0.04%
==========================================
Files 229 233 +4
Lines 25813 26077 +264
Branches 9390 9474 +84
==========================================
+ Hits 24777 25041 +264
Misses 425 425
Partials 611 611 🚀 New features to boost your workflow:
|
Summary
gate.size.mode,gate.dryRun,gate.selfAuthoredLinkedIssue, andgate.aiReview.closeConfidenceare all fully parsed byparseGateConfigand applied byresolveEffectiveSettings— real, working, enforced knobs — but none appeared in.gittensory.yml.example's documentedgate:block.size.mode,dryRun,aiReview.closeConfidence) are config-as-code only, with no DB column or dashboard equivalent;selfAuthoredLinkedIssuehas a real DB column (self_authored_linked_issue_gate_mode) that the yml value overrides.Scope
.gittensory.yml.example— added all 4 knobs with the exact doc-comment convention already used for every othergate:sub-field, noting config-as-code-only scope where applicable.test/unit/focus-manifest.test.ts— added a regression test that parses the actual.gittensory.yml.examplefile through the real parser and asserts zero warnings, plus round-trips the 4 new knobs, so documentation can never silently drift from parser behavior again.Validation
npx vitest run test/unit/focus-manifest.test.ts— 158/158 passingnpm run typecheck— cleannpm run test:ci— full local gate greennpm audit --audit-level=moderate— 0 vulnerabilitiesSafety
src/**andtest/**; no workflow/review-engine/visual-capture paths touched.Closes #2554