Skip to content

docs(config): document 4 real gate knobs missing from .gittensory.yml.example#2594

Merged
JSONbored merged 1 commit into
mainfrom
docs/gate-config-example-missing-knobs-v2
Jul 2, 2026
Merged

docs(config): document 4 real gate knobs missing from .gittensory.yml.example#2594
JSONbored merged 1 commit into
mainfrom
docs/gate-config-example-missing-knobs-v2

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

  • gate.size.mode, gate.dryRun, gate.selfAuthoredLinkedIssue, and gate.aiReview.closeConfidence are all fully parsed by parseGateConfig and applied by resolveEffectiveSettings — real, working, enforced knobs — but none appeared in .gittensory.yml.example's documented gate: block.
  • Three of the four (size.mode, dryRun, aiReview.closeConfidence) are config-as-code only, with no DB column or dashboard equivalent; selfAuthoredLinkedIssue has a real DB column (self_authored_linked_issue_gate_mode) that the yml value overrides.

Scope

  • .gittensory.yml.example — added all 4 knobs with the exact doc-comment convention already used for every other gate: sub-field, noting config-as-code-only scope where applicable.
  • test/unit/focus-manifest.test.ts — added a regression test that parses the actual .gittensory.yml.example file through the real parser and asserts zero warnings, plus round-trips the 4 new knobs, so documentation can never silently drift from parser behavior again.

Validation

  • npx vitest run test/unit/focus-manifest.test.ts — 158/158 passing
  • npm run typecheck — clean
  • npm run test:ci — full local gate green
  • npm audit --audit-level=moderate — 0 vulnerabilities

Safety

  • Docs-only change plus one new test; no runtime behavior changed.
  • Stays within src/** and test/**; no workflow/review-engine/visual-capture paths touched.

Closes #2554

….example

gate.size.mode, gate.dryRun, gate.selfAuthoredLinkedIssue, and
gate.aiReview.closeConfidence are all fully parsed by parseGateConfig
and applied by resolveEffectiveSettings -- real, working, enforced
knobs -- but none appeared in .gittensory.yml.example's documented
gate: block. Three of the four (size.mode, dryRun, aiReview.closeConfidence)
are config-as-code only, with no DB column or dashboard equivalent;
selfAuthoredLinkedIssue has a real DB column
(self_authored_linked_issue_gate_mode) the yml value overrides.

Added all 4 to the example file with the exact doc-comment convention
already used for every other gate sub-field, noting config-as-code-only
scope where applicable. Added a regression test that parses the actual
.gittensory.yml.example file through the real parser and asserts zero
warnings plus round-trips the 4 new knobs, so documentation can never
silently drift from parser behavior again.
@dosubot dosubot Bot added the size:S label Jul 2, 2026
@loopover-orb

loopover-orb Bot commented Jul 2, 2026

Copy link
Copy Markdown

Tip

🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

✅ Gittensory review result - approve/merge recommended

Review updated: 2026-07-02 12:06:39 UTC

2 files · 1 AI reviewer · no blockers · readiness 82/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This change documents four already-parsed gate settings in `.gittensory.yml.example` and adds a focused parser regression test against the real example file. The visible diff is coherent with the PR description, and the new assertions cover the four newly documented knobs without changing runtime behavior. The only notable maintainability issue is that the test reads the example through a cwd-relative path, which is acceptable in current CI but less robust than file-relative resolution.

Nits — 3 non-blocking
  • nit: test/unit/focus-manifest.test.ts:170 reads `.gittensory.yml.example` through a process-cwd-relative path; using file-relative resolution would keep this regression test stable under alternate Vitest cwd or package-level invocation.
  • test/unit/focus-manifest.test.ts:170: derive the example path from the test file location or a shared repo-root helper before calling `readFileSync`, so the regression test is not coupled to the caller's working directory.
  • PR author also opened the linked issue — Link an issue that was opened by a different contributor, or provide a rationale for why this self-authored issue represents genuine discovery work.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #2554
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (size label size:S; 1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 65 registered-repo PR(s), 55 merged, 536 issue(s).
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 65 PR(s), 536 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
Contributor next steps
  • Treat this as maintainer-lane context rather than normal contributor-lane activity.
  • Review top overlaps.
  • Add a concise scope and risk note.
  • No action.
  • Check active issues and PRs before submitting.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot added gittensor gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. labels Jul 2, 2026
@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.02%. Comparing base (335d9cd) to head (1a712a0).
⚠️ Report is 10 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2594      +/-   ##
==========================================
+ Coverage   95.98%   96.02%   +0.04%     
==========================================
  Files         229      233       +4     
  Lines       25813    26077     +264     
  Branches     9390     9474      +84     
==========================================
+ Hits        24777    25041     +264     
  Misses        425      425              
  Partials      611      611              
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JSONbored
JSONbored merged commit eca8fba into main Jul 2, 2026
12 checks passed
@JSONbored
JSONbored deleted the docs/gate-config-example-missing-knobs-v2 branch July 2, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(config): document 4 real gate knobs missing from .gittensory.yml.example

1 participant