Skip to content

feat(rees): flag host-network and K8s TLS-skip in IaC patches#2651

Merged
JSONbored merged 1 commit into
JSONbored:mainfrom
kiannidev:feat/rees-iac-host-network-tls
Jul 3, 2026
Merged

feat(rees): flag host-network and K8s TLS-skip in IaC patches#2651
JSONbored merged 1 commit into
JSONbored:mainfrom
kiannidev:feat/rees-iac-host-network-tls

Conversation

@kiannidev

@kiannidev kiannidev commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Extends iacMisconfig to flag added lines with hostNetwork: true, Docker Compose network_mode: host, and Kubernetes/Helm insecureSkipTLSVerify / skipTLSVerify settings.
  • Reuses existing finding kinds (open-ingress, tls-verification-disabled) — no registry/types/render changes.

Scope

  • Focused review-enrichment/ analyzer + dedicated test file (avoids collisions with open analyzer PRs).
  • No linked issue — self-contained enrichment signal.

Validation

  • review-enrichment build + node --test test/iac-misconfig.test.ts — 4/4 passing

Safety

  • Patch-line scanner only; no network calls.

Extend the iacMisconfig analyzer to detect hostNetwork, compose host
network_mode, and insecureSkipTLSVerify / skipTLSVerify additions.

Co-authored-by: Cursor <cursoragent@cursor.com>
@kiannidev
kiannidev requested a review from JSONbored as a code owner July 3, 2026 00:27
@dosubot dosubot Bot added the size:XS label Jul 3, 2026
@loopover-orb

loopover-orb Bot commented Jul 3, 2026

Copy link
Copy Markdown

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-03 02:44:13 UTC

2 files · 1 AI reviewer · no blockers · readiness 73/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
The change cleanly extends the existing patch-line IaC scanner with host-network and Kubernetes/Helm TLS-skip patterns, reusing the existing finding kinds without widening the downstream contract. The new checks are on added lines only, honor the existing max-finding/abort behavior, and the dedicated tests cover the reachable scanner path for both new signal groups.

Nits — 5 non-blocking
  • nit: review-enrichment/src/analyzers/iac-misconfig.ts:16 and review-enrichment/src/analyzers/iac-misconfig.ts:23 still scan comments and could flag an added commented example like `# hostNetwork: true`; consider stripping trailing/comment-only YAML comments if false positives are a concern.
  • nit: review-enrichment/test/iac-misconfig.test.ts:6 combines the Kubernetes and Docker Compose host-network cases in one assertion block, so splitting them would make future failures more localized.
  • review-enrichment/test/iac-misconfig.test.ts:19 should add a quoted boolean case for `insecureSkipTLSVerify: "true"` as well, matching the Helm `skipTLSVerify` coverage.
  • review-enrichment/test/iac-misconfig.test.ts:6 could include a negative case for `hostNetwork: false` / `network_mode: bridge` to pin the new regex boundaries.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (size label size:XS; no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 1689 registered-repo PR(s), 836 merged, 40 issue(s).
Contributor context ✅ Confirmed Gittensor contributor kiannidev; Gittensor profile; 1689 PR(s), 40 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: kiannidev
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 1689 PR(s), 40 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Explain no-issue PR.
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@dosubot dosubot Bot added the lgtm label Jul 3, 2026
@JSONbored
JSONbored merged commit cbb7aee into JSONbored:main Jul 3, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Development

Successfully merging this pull request may close these issues.

2 participants