fix(signals): classify bower_components and jspm_packages as vendored#2777
Conversation
isVendoredFileFrom recognized node_modules and vendor/third_party dirs, but not bower_components (Bower) or jspm_packages (JSPM) — installed-dependency directories in the same vendored category, not contributor source. Changes under them were miscounted as substantive source effort. Add both to the vendored-directory matcher and cover them.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2777 +/- ##
=======================================
Coverage 96.09% 96.09%
=======================================
Files 245 245
Lines 27391 27391
Branches 9947 9947
=======================================
Hits 26322 26322
Misses 443 443
Partials 626 626
🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-03 18:38:28 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 3 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
… provenance (#2799) The provenance analyzer's VENDORED_PATH_RE recognized vendor/node_modules/third_party but not bower_components (Bower) or jspm_packages (JSPM) — installed-dependency directories that are the same vendored case as node_modules. #2777 added exactly these to the server-side path classifier (src/signals/path-matchers.ts), but review-enrichment ships as a standalone package with its own copy, so the fix did not reach it. A committed bower/jspm tree therefore fell through to null (ordinary source) instead of "vendored", so the provenance analyzer treated vendored third-party code as reviewable contributor source. Add both directories to VENDORED_PATH_RE (directory-segment anchored, so a source file merely named like the dir is unaffected). Adds a provenance regression.
Summary
isVendoredFileFromrecognizednode_modulesand vendor/third_party dirs, but notbower_components(Bower) orjspm_packages(JSPM) — installed-dependency directories in the same vendored category, not contributor source. Changes under them were miscounted as substantive source effort.Adds both to the vendored-directory matcher.
Validation
npx vitest run test/unit/path-matchers.test.ts— greennpm run typecheck— clean