fix(signals): classify Vue/Svelte/Astro source files as code#3282
fix(signals): classify Vue/Svelte/Astro source files as code#3282jimcody1995 wants to merge 1 commit into
Conversation
Align isCodeFile with review/rag.ts CODE_EXT_RE and review/visual/paths.ts so front-end framework source is counted as genuine code in slop signals, missing-tests checks, and the MCP local score preview mirrors. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Caution 🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥 🛑 Gittensory review result - reject/close recommendedReview updated: 2026-07-05 00:41:17 UTC
🛑 Suggested Action - Reject/Close
Review summary Blockers
Nits — 5 non-blocking
Why this is blocked
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
|
Gittensory is closing this pull request on the maintainer's behalf (AI reviewers agree on a likely critical defect: src/rules/advisory.ts:isCodePath still excludes `.vue`, `.svelte`, and `.astro`, so `buildCheckRunAnnotations` filters those files out before the new `isCodeFile` predicate can classify them and the missing-test annotation path remains broken for exactly the framework files this PR is meant to fix.). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3282 +/- ##
=======================================
Coverage 94.13% 94.13%
=======================================
Files 276 276
Lines 30204 30204
Branches 11011 11011
=======================================
Hits 28432 28432
Misses 1127 1127
Partials 645 645
🚀 New features to boost your workflow:
|
Summary
Vue, Svelte, and Astro source files were already treated as code by the RAG indexer (
review/rag.tsCODE_EXT_RE) and the visual-path classifier (review/visual/paths.ts), butisCodeFiledid not recognize them. That mismatch meant front-end framework changes could be misclassified as non-code in slop signals, missing-tests checks, and the MCP local score preview.This PR extends
isCodeFile(and the mirrored MCP classifiers) to include.vue,.svelte, and.astroextensions, with regression tests in the classifier suite, MCP parity test, and score-preview script tests.No linked issue — small classifier parity fix with clear product impact.
Conflict avoidance: This PR touches only
src/signals/{local-branch,engine}.ts, MCP score-preview mirrors, and related unit tests. None of the four currently open PRs (#3278, #3273, #3269, #3255) modify these paths, so it should merge cleanly even after those land.Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
npm run test:ciandnpm audit --audit-level=moderateboth passed locally on latestmain(commit d9dfcf8).Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
N/A — no visible UI change.
Notes
isCodeFileinlocal-branch.ts,engine.ts, and the MCP score-preview mirrors (.mjs,.py,local-branch.js) in sync.local-branch.test.tsandscore-preview-script.test.tsfor both.mjsand.pypaths.