fix(signals): classify .cc and .hpp C++ source across all classifiers#3301
Conversation
Extend isCodeFile and advisory isCodePath to recognize .cc and .hpp so native C++ changes align with review/rag.ts indexing and receive correct slop, missing-tests, and check-run annotation treatment. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-05 01:22:39 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 3 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3301 +/- ##
=======================================
Coverage 94.14% 94.14%
=======================================
Files 276 276
Lines 30246 30246
Branches 11021 11021
=======================================
Hits 28474 28474
Misses 1127 1127
Partials 645 645
🚀 New features to boost your workflow:
|
…#3301) Extend isCodeFile and advisory isCodePath to recognize .cc and .hpp so native C++ changes align with review/rag.ts indexing and receive correct slop, missing-tests, and check-run annotation treatment. Co-authored-by: Cursor <cursoragent@cursor.com>
Summary
The RAG indexer (
review/rag.ts) already treats.ccand.hppas code, butisCodeFileandisCodePathonly recognized.cpp,.c, and.h. PRs touching only.cc/.hppnative sources could be misclassified as non-code in slop signals, missing-tests checks, and check-run annotations.This PR extends both
isCodeFileandisCodePath(plus MCP score-preview mirrors) to include.ccand.hpp, following the same all-classifier parity pattern as #3292.No linked issue — small classifier parity fix with clear product impact.
Conflict avoidance: Touches
src/signals/,src/rules/advisory.ts, MCP score-preview mirrors, and unit tests. None of the ten currently open PRs (#3299, #3298, #3297, #3295, #3294, #3291, #3290, #3289, #3281, #3255) modify these paths.Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
npm run test:ciandnpm audit --audit-level=moderateboth passed locally on latestmain(commit cc27827).Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
N/A — no visible UI change.
Notes
isCodeFile,isCodePath, and MCP mirrors in the same PR so no classifier drifts.rules.test.tsassert.cc/.hppfiles receive missing-test annotations.