Skip to content

feat(enrichment): detect Gladia and WorkOS legacy API keys - #3325

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
bohdansolovie:feat/secret-scan-gladia-minimax
Jul 5, 2026
Merged

feat(enrichment): detect Gladia and WorkOS legacy API keys#3325
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
bohdansolovie:feat/secret-scan-gladia-minimax

Conversation

@bohdansolovie

Copy link
Copy Markdown
Contributor

Summary

  • Add gladia_api_key rule for Gladia gla_ API keys
  • Add workos_legacy_api_key rule for WorkOS legacy wos_api_key_ tokens (avoids generic sk_ conflict with current WorkOS keys)
  • Include positive, truncation, and _suffix/-suffix identifier-continuation negative tests

Test plan

  • cd review-enrichment && npm run build && node --test test/secret-scan.test.ts (90 passing)

Made with Cursor

Add high-confidence secret-scan rules for Gladia gla_ keys and WorkOS
legacy wos_api_key_ tokens, with truncation and identifier-continuation
negative tests.

Co-authored-by: Cursor <cursoragent@cursor.com>
@bohdansolovie
bohdansolovie requested a review from JSONbored as a code owner July 5, 2026 02:46
@superagent-security

Copy link
Copy Markdown
Contributor

🚨 Contributor flagged. Click here for more info: Superagent Dashboard

@superagent-security superagent-security Bot added the contributor:flagged Contributor flagged for review by trust analysis. label Jul 5, 2026
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 5, 2026
@loopover-orb

loopover-orb Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-05 02:46:52 UTC

2 files · 1 AI reviewer · no blockers · readiness 73/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This is a narrow enrichment update that adds two high-confidence secret-scan rules and covers the happy path plus truncation and identifier-continuation negatives. The new regexes follow the surrounding rule style: fixed provider prefix, minimum body length, and a trailing guard against consuming partial identifiers. I do not see a reachable correctness break in the visible diff.

Nits — 6 non-blocking
  • nit: review-enrichment/src/analyzers/secret-scan.ts:346 should include a provenance note or vendor-format source for `gla_` because this rule’s precision depends entirely on the undocumented prefix/body assumption.
  • nit: review-enrichment/src/analyzers/secret-scan.ts:353 should include the same provenance note for `wos_api_key_`, especially because the PR explicitly avoids current WorkOS `sk_` keys and this is a legacy-only format.
  • nit: review-enrichment/test/secret-scan.test.ts:966 only tests repeated lowercase bodies, so it does not lock in the intended `[A-Za-z0-9]` coverage for uppercase and digits.
  • review-enrichment/src/analyzers/secret-scan.ts:346 add a short source/provenance comment for the Gladia key format, or point to the existing convention if another rule already documents externally sourced formats.
  • review-enrichment/src/analyzers/secret-scan.ts:353 add a short source/provenance comment explaining that this intentionally covers only legacy WorkOS `wos_api_key_` tokens and not current `sk_` keys.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 216 registered-repo PR(s), 130 merged, 9 issue(s).
Contributor context ✅ Confirmed Gittensor contributor bohdansolovie; Gittensor profile; 216 PR(s), 9 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: bohdansolovie
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 216 PR(s), 9 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Explain no-issue PR.
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit ab7dce6 into JSONbored:main Jul 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor:flagged Contributor flagged for review by trust analysis. gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant