feat(review): treat Azure App Service + Fly.io as multi-tenant suffixes - #3403
Conversation
MULTI_TENANT_SUFFIXES kept a tenant label deep for github.io/herokuapp.com/etc. so distinct tenants don't collapse to a shared registrable domain, but omitted azurewebsites.net (Azure App Service) and fly.dev (Fly.io). Without them, alice.azurewebsites.net and bob.azurewebsites.net both reduce to the bare suffix, letting two unrelated parties falsely satisfy the same host claim in hostMatchesClaim. Add both (peers of herokuapp.com/onrender.com) and extend the registrableDomain multi-tenant test.
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3403 +/- ##
=======================================
Coverage 93.46% 93.46%
=======================================
Files 289 289
Lines 30784 30784
Branches 11220 11220
=======================================
Hits 28773 28773
Misses 1355 1355
Partials 656 656
🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-05 06:20:54 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 4 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
MULTI_TENANT_SUFFIXES keeps a tenant label deep for github.io/herokuapp.com/etc. so distinct tenants dont collapse to a shared registrable domain, but omitted azurewebsites.net (Azure App Service) and fly.dev (Fly.io). Without them, alice.azurewebsites.net and bob.azurewebsites.net both reduce to the bare suffix, letting two unrelated parties falsely satisfy the same host claim. Adds both + extends the registrableDomain test. Rebased onto current main; tsc + tests (133) green.