Skip to content

feat(review): treat Azure App Service + Fly.io as multi-tenant suffixes - #3403

Merged
loopover-orb[bot] merged 2 commits into
JSONbored:mainfrom
jeffrey701:feat/registry-multitenant-azure-fly
Jul 5, 2026
Merged

feat(review): treat Azure App Service + Fly.io as multi-tenant suffixes#3403
loopover-orb[bot] merged 2 commits into
JSONbored:mainfrom
jeffrey701:feat/registry-multitenant-azure-fly

Conversation

@jeffrey701

Copy link
Copy Markdown
Contributor

MULTI_TENANT_SUFFIXES keeps a tenant label deep for github.io/herokuapp.com/etc. so distinct tenants dont collapse to a shared registrable domain, but omitted azurewebsites.net (Azure App Service) and fly.dev (Fly.io). Without them, alice.azurewebsites.net and bob.azurewebsites.net both reduce to the bare suffix, letting two unrelated parties falsely satisfy the same host claim. Adds both + extends the registrableDomain test. Rebased onto current main; tsc + tests (133) green.

MULTI_TENANT_SUFFIXES kept a tenant label deep for github.io/herokuapp.com/etc.
so distinct tenants don't collapse to a shared registrable domain, but omitted
azurewebsites.net (Azure App Service) and fly.dev (Fly.io). Without them,
alice.azurewebsites.net and bob.azurewebsites.net both reduce to the bare
suffix, letting two unrelated parties falsely satisfy the same host claim in
hostMatchesClaim. Add both (peers of herokuapp.com/onrender.com) and extend the
registrableDomain multi-tenant test.
@jeffrey701
jeffrey701 requested a review from JSONbored as a code owner July 5, 2026 06:16
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.46%. Comparing base (708d141) to head (215df57).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3403   +/-   ##
=======================================
  Coverage   93.46%   93.46%           
=======================================
  Files         289      289           
  Lines       30784    30784           
  Branches    11220    11220           
=======================================
  Hits        28773    28773           
  Misses       1355     1355           
  Partials      656      656           
Files with missing lines Coverage Δ
src/review/content-lane/registry-logic.ts 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 5, 2026
@loopover-orb

loopover-orb Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-05 06:20:54 UTC

2 files · 1 AI reviewer · no blockers · readiness 73/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
The change correctly adds the primary Azure App Service and Fly.io shared suffixes to the multi-tenant list and extends the direct tenant-label regression test. For the visible happy paths, alice.azurewebsites.net and bob.fly.dev now retain the tenant label instead of collapsing to the bare platform suffix. I do not see a blocking defect in the diff, but Azure App Service has an important nested SCM hostname shape that this test does not cover.

Nits — 4 non-blocking
  • nit: src/review/content-lane/registry-logic.ts:203 should either document or cover the Azure SCM hostname shape, because appname.scm.azurewebsites.net would still resolve to scm.azurewebsites.net under the current "last label before suffix" rule rather than appname.scm.azurewebsites.net.
  • test/unit/content-lane-registry-logic.test.ts:683 add an explicit expectation for the Azure SCM endpoint shape, or state why those hosts are intentionally out of scope for this claim logic: ```expect(registrableDomain("https:​//alice.scm.azurewebsites.net/")).toBe("alice.scm.azurewebsites.net");```
  • src/review/content-lane/registry-logic.ts:203 if SCM hosts are in scope, handle `scm.azurewebsites.net` as its own multi-tenant suffix ahead of `azurewebsites.net` so the tenant label stays one level deeper.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 66 registered-repo PR(s), 35 merged, 0 issue(s).
Contributor context ✅ Confirmed Gittensor contributor jeffrey701; Gittensor profile; 66 PR(s), 0 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: jeffrey701
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 66 PR(s), 0 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Explain no-issue PR.
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit bc98138 into JSONbored:main Jul 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant