test(enrichment): cover extractFunctionParams multi-line and TS param shapes - #3407
Conversation
… shapes The two existing tests only fed single-line signatures. Adds the uncovered branches: a multi-line signature (extractParamSource's line walk), a rest parameter (`...` stripped), TS type annotations and default values stripped to names, and a `this` pseudo-parameter skipped. Test-only.
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-05 06:24:59 UTC
⏸️ Suggested Action - Manual Review Review summary
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Summary
Hardens unit coverage for the
doc-comment-driftanalyzer's pureextractFunctionParamshelper. Its two existing tests only feed single-line signatures, leaving several real branches uncovered — this adds four:extractParamSource's line-walking) → params still extracted...rest) → the...marker is stripped, the name kepta: string, b = 5) → stripped down to the plain namesthispseudo-parameter → skipped, keeping the real argsTest-only, against the compiled
dist/, in the analyzer's own test file. No source or shared-registry change.No linked issue — branch-coverage hardening of a pure function; no runtime behavior change.
Scope
review-enrichment/test/doc-comment-drift.test.ts. Nosite//CNAME/**/lovable/**; noCHANGELOG.md.Validation
npm --prefix review-enrichment test— full suite green (build + sourcemap validate +metadata --check+ node tests; exactly CI). Each new assertion was traced againstextractParamSource/parseFunctionParamsand confirmed.git diff --checkclean.Safety