Skip to content

feat(engine): add hasPlanPendingSteps - #3413

Merged
JSONbored merged 1 commit into
JSONbored:mainfrom
kiannidev:feat/engine-has-plan-pending-steps
Jul 5, 2026
Merged

feat(engine): add hasPlanPendingSteps#3413
JSONbored merged 1 commit into
JSONbored:mainfrom
kiannidev:feat/engine-has-plan-pending-steps

Conversation

@kiannidev

Copy link
Copy Markdown
Contributor

Summary

  • Add hasPlanPendingSteps in @jsonbored/gittensory-engine — returns whether any step in a plan DAG is still pending.
  • Pure helper alongside hasPlanFailedSteps and isPlanFullyCompleted for miner and dashboard status checks.
  • Vitest coverage at 100% patch on the new helper.

Test plan

  • COVERAGE_NO_THRESHOLDS=1 npx vitest run test/unit/plan-pending.test.ts --coverage
  • npx diff-cover coverage/lcov.info --compare-branch=main --fail-under=99 → 100%
  • npm run build --workspace @jsonbored/gittensory-engine && npm run build:miner

Made with Cursor

Expose a pure plan-DAG pending check for miner and dashboard flows that need a quick in-progress signal.

Co-authored-by: Cursor <cursoragent@cursor.com>
@kiannidev
kiannidev requested a review from JSONbored as a code owner July 5, 2026 06:36
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jul 5, 2026
@loopover-orb

loopover-orb Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-05 06:36:54 UTC

3 files · 1 AI reviewer · no blockers · readiness 55/100 · CI pending · blocked

⏸️ Suggested Action - Manual Review

Review summary
This PR adds a narrow pure helper that matches the existing plan status helpers: it reads `PlanDag.steps` and returns true when any step has `status === "pending"`, then exports it from the engine barrel. The unit coverage exercises the empty, false, true, and barrel-export paths, and the implementation is correctly scoped with no reachable correctness issue in the visible diff.

Nits — 2 non-blocking
  • packages/gittensory-engine/src/plan-pending.ts:4: Consider matching the neighboring helper docs exactly if `plan-completion.ts` and `plan-failure.ts` use a shared wording pattern, so these plan status helpers stay visually consistent.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 1362 registered-repo PR(s), 668 merged, 49 issue(s).
Contributor context ✅ Confirmed Gittensor contributor kiannidev; Gittensor profile; 1362 PR(s), 49 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: kiannidev
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: TypeScript, MDX, C++, HTML, Rust
  • Official Gittensor activity: 1362 PR(s), 49 issue(s).
  • Related work: Titles/paths share 10 meaningful terms. (issue #2281, issue #2276)
  • Related work: Titles/paths share 8 meaningful terms. (issue #2281, issue #2287)
  • Related work: Titles/paths share 8 meaningful terms. (issue #2276, issue #2287)
Contributor next steps
  • Explain no-issue PR.
  • Review top overlaps.
  • Add a concise scope and risk note.
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
  • Check active issues and PRs before submitting.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.46%. Comparing base (102ca62) to head (3a8d990).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3413   +/-   ##
=======================================
  Coverage   93.46%   93.46%           
=======================================
  Files         291      292    +1     
  Lines       30790    30791    +1     
  Branches    11221    11221           
=======================================
+ Hits        28779    28780    +1     
  Misses       1355     1355           
  Partials      656      656           
Files with missing lines Coverage Δ
packages/gittensory-engine/src/plan-pending.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JSONbored
JSONbored merged commit f5a03bb into JSONbored:main Jul 5, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Development

Successfully merging this pull request may close these issues.

2 participants