Skip to content

feat(review): add review.tone public-safe voice brief knob (#2044)#3506

Closed
RealDiligent wants to merge 1 commit into
JSONbored:mainfrom
RealDiligent:feat/review-tone-2044
Closed

feat(review): add review.tone public-safe voice brief knob (#2044)#3506
RealDiligent wants to merge 1 commit into
JSONbored:mainfrom
RealDiligent:feat/review-tone-2044

Conversation

@RealDiligent

Copy link
Copy Markdown
Contributor

Closes #2044. Part of #1959.

@RealDiligent
RealDiligent requested a review from JSONbored as a code owner July 5, 2026 14:37
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jul 5, 2026
@loopover-orb

loopover-orb Bot commented Jul 5, 2026

Copy link
Copy Markdown

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-05 14:39:56 UTC

5 files · 1 AI reviewer · no blockers · readiness 62/100 · CI pending · dirty

⏸️ Suggested Action - Manual Review

Review summary
The change threads `review.tone` through manifest parsing, serialization, prompt override resolution, and the queue processor call site, with focused tests covering parsing, public-safe rejection, round-tripping, and composition with existing instructions. The implementation keeps the default/null path byte-identical for the resolved prompt override and does not introduce a schema or migration concern because this is manifest-only config. No reachable correctness defect is visible in the provided diff.

Nits — 5 non-blocking
  • nit: `src/signals/focus-manifest.ts:1848` uses a fairly long literal label inside the prompt composition; consider extracting the section label to a small constant so the test and implementation do not drift if the wording changes.
  • nit: `.gittensory.yml.example:578` documents `tone` after `path_filters`, while the parser treats it as a top-level `review` field; keeping it near `profile` would make the relationship between the two knobs easier for operators to discover.
  • In `src/signals/focus-manifest.ts:1848`, define a `REVIEW_TONE_SECTION_LABEL` constant and reuse it in `composeManifestReviewInstructions` and the unit expectation.
  • In `.gittensory.yml.example:578`, move the `tone` example adjacent to `profile` so the public voice knob is documented next to the volume knob it complements.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #2044
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (1 linked issue).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 163 registered-repo PR(s), 28 merged, 0 issue(s).
Contributor context ✅ Confirmed Gittensor contributor RealDiligent; Gittensor profile; 163 PR(s), 0 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: RealDiligent
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: JavaScript, Ruby, Svelte, TypeScript, Cuda, Markdown
  • Official Gittensor activity: 163 PR(s), 0 issue(s).
  • Related work: Titles/paths share 7 meaningful terms. (issue #2044, issue #2046)
  • Related work: Titles/paths share 7 meaningful terms. (issue #2044, issue #2045)
  • Related work: Titles/paths share 8 meaningful terms. (issue #2044, issue #2047)
  • Additional title-only matches omitted; title-only overlap does not block.
Contributor next steps
  • Review top overlaps.
  • Add a concise scope and risk note.
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
  • Check active issues and PRs before submitting.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb

loopover-orb Bot commented Jul 5, 2026

Copy link
Copy Markdown

Gittensory is closing this pull request on the maintainer's behalf (conflicts with the base branch — resolve and open a fresh PR). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(config): add review.tone public-safe free-text brief knob

1 participant