Skip to content

fix(selfhost): ignore timestamped config/deploy backup directories - #3568

Merged
JSONbored merged 1 commit into
mainfrom
fix/deploy-backup-gitignore-gap
Jul 5, 2026
Merged

fix(selfhost): ignore timestamped config/deploy backup directories#3568
JSONbored merged 1 commit into
mainfrom
fix/deploy-backup-gitignore-gap

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

  • gittensory-config/ was ignored, but operator tooling can create sibling backup snapshots
    under different directory names (gittensory-config.backup-<timestamp>/, .deploy-backups/)
    that the existing pattern doesn't match, leaving them untracked and unignored.
  • Adds both patterns alongside the existing gittensory-config/ entry, same exposure class.

Test plan

  • .gitignore-only change; no src/** impact, nothing to unit test.
  • Verified locally with git status --porcelain + a git add -An dry run that both
    directory shapes are now correctly ignored.

gittensory-config/ was ignored, but operator tooling can create sibling
backup snapshots (gittensory-config.backup-<timestamp>/, .deploy-backups/)
under different directory names that the existing pattern didn't match,
leaving them untracked and unignored.
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 5, 2026
@loopover-orb

loopover-orb Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-05 17:24:59 UTC

1 file · 1 AI reviewer · 2 blockers · readiness 93/100 · CI green · clean

⏸️ Suggested Action - Manual Review

  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
  • Maintainer requires a linked issue — Link the relevant issue (for example Closes #123) before opening the PR.

Review summary
This is a pure .gitignore addition that extends the existing gittensory-config/ ignore rule with two new patterns (gittensory-config.backup-*/ and .deploy-backups/) to cover operator backup directories that weren't previously matched. The change is inert with respect to build/runtime behavior, scoped correctly to non-src/ tooling config, and the patterns are syntactically valid gitignore globs. No migration, schema, or code-path impact exists to verify.

Nits — 3 non-blocking
  • The .deploy-backups/ pattern anchors only at the repo root (leading no wildcard), so nested instances like apps/foo/.deploy-backups/ would not be ignored — confirm that matches the intended scope, or use **/.deploy-backups/ for parity with the .codex/ entries a few lines below.
  • No test/verification beyond a manual git status dry run is expected or needed for a .gitignore-only change, so the test plan checkboxes are appropriately minimal.
  • If deploy-backup snapshots can also appear under nested subdirectories (e.g. per-service self-host setups), mirror the **/.codex/ pattern already in the file and add **/.deploy-backups/ for consistency.

Concerns raised — review before merging

  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
  • Maintainer requires a linked issue — Link the relevant issue (for example Closes #123) before opening the PR.
Signal Result Evidence
Code review ❌ 2 blockers 1 reviewer
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (no linked issue context).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 56 registered-repo PR(s), 46 merged, 521 issue(s).
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 56 PR(s), 521 issue(s).
Gate result ❌ Blocking Repo-configured hard blocker found.
Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: Python, TypeScript, JavaScript, Ruby, Go, Kotlin, MDX, Shell
  • Official Gittensor activity: 56 PR(s), 521 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Treat this as maintainer-lane context rather than normal contributor-lane activity.
  • Explain no-issue PR.
  • No action.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot added the manual-review Gittensor contributor context label Jul 5, 2026
@JSONbored
JSONbored merged commit 63185d4 into main Jul 5, 2026
8 checks passed
@JSONbored
JSONbored deleted the fix/deploy-backup-gitignore-gap branch July 5, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. manual-review Gittensor contributor context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant