fix(selfhost): guard pg queue coalesce UPDATEs with status=pending - #3595
fix(selfhost): guard pg queue coalesce UPDATEs with status=pending#3595RealDiligent wants to merge 1 commit into
Conversation
Supersede and simple-coalesce paths now mirror the merge-path gate finding: lose the SELECT-then-UPDATE race cleanly (rowCount 0) and fall through to INSERT instead of overwriting a row another instance already claimed. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Caution 🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥 🛑 Gittensory review result - reject/close recommendedReview updated: 2026-07-05 18:22:45 UTC
🛑 Suggested Action - Reject/Close
Review summary Nits — 2 non-blocking
Why this is blocked
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
|
Gittensory is closing this pull request on the maintainer's behalf (No linked issue detected; Maintainer requires a linked issue). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3595 +/- ##
=======================================
Coverage 93.19% 93.19%
=======================================
Files 313 313
Lines 31874 31874
Branches 11666 11666
=======================================
Hits 29705 29705
Misses 1517 1517
Partials 652 652 🚀 New features to boost your workflow:
|
Summary
status='pending'guards to Postgres queue supersede and simple-coalesce UPDATE pathsrowCount === 0), fall through to INSERT instead of silently overwriting a row another instance claimedenqueue()functionTest plan
npm run typechecknpx vitest run test/unit/selfhost-pg-queue.test.ts