Skip to content

chore(ci): wire gittensory-engine and gittensory-miner path filters#3599

Merged
JSONbored merged 1 commit into
JSONbored:mainfrom
kiannidev:feat/ci-engine-miner-filters
Jul 5, 2026
Merged

chore(ci): wire gittensory-engine and gittensory-miner path filters#3599
JSONbored merged 1 commit into
JSONbored:mainfrom
kiannidev:feat/ci-engine-miner-filters

Conversation

@kiannidev

Copy link
Copy Markdown
Contributor

Summary

  • Add engine and miner path filters to the CI changes job
  • Run engine build, miner build, and miner pack check when those paths change (or on push to main)
  • Extend validate-code job gating so engine/miner-only PRs still enter the workflow
  • Add a regression test asserting the workflow declares the expected filters and steps

Closes #2297

Test plan

  • npx vitest run test/unit/ci-engine-miner-filters.test.ts
  • npm run actionlint

Made with Cursor

Closes JSONbored#2297

Add engine/miner CI filters and conditional build/pack-check steps.

Co-authored-by: Cursor <cursoragent@cursor.com>
@kiannidev
kiannidev requested a review from JSONbored as a code owner July 5, 2026 18:31
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 5, 2026
@loopover-orb

loopover-orb Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-05 18:58:53 UTC

2 files · 1 AI reviewer · no blockers · readiness 80/100 · CI green · clean

⏸️ Suggested Action - Manual Review

  • Touches a guarded path — held for manual review: This PR changes guardrail-protected path(s): .github/workflows/ci.yml (matched .github/workflows/**).

Review summary
This is a narrowly-scoped CI wiring change adding `engine` and `miner` path filters to the `changes` job, gating new engine/miner build and pack-check steps, and extending `validate-code`'s trigger condition so engine/miner-only PRs still run the workflow. The pattern mirrors the existing `mcp` filter closely (including package-lock.json as a shared trigger), and the added regression test is a straightforward string/regex assertion against the committed YAML confirming the filters and step names exist. All CI checks passed on this commit, and the PR closes the linked issue #2297.

Nits — 5 non-blocking
  • test/unit/ci-engine-miner-filters.test.ts asserts on raw YAML text via regex/toContain rather than parsing the workflow, so it can pass on coincidental text matches elsewhere in the file — acceptable given this mirrors likely existing conventions for other filter regression tests in this repo, but worth confirming that convention is what's followed here.
  • The `engine` and `miner` filters both include 'package-lock.json' as a trigger path, same as the existing `mcp` filter — consistent, but means any lockfile-only change now runs three extra build/pack steps unconditionally; worth a one-line confirmation that's intended rather than accidental scope creep from copy-pasting the mcp block.
  • Consider whether the lockfile-triggers-everything pattern (shared across backend/mcp/engine/miner filters) should eventually be narrowed or documented in one place instead of repeated per filter block in .github/workflows/ci.yml.
  • If not already covered elsewhere, add a brief comment near the new engine/miner filter blocks (similar to the existing MCP CLI-cluster comment) explaining why package-lock.json is included, for future maintainers scanning the filters.
  • Touches a guarded path — held for manual review — A maintainer must review and merge this change.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #2297
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 1458 registered-repo PR(s), 751 merged, 48 issue(s).
Contributor context ✅ Confirmed Gittensor contributor kiannidev; Gittensor profile; 1458 PR(s), 48 issue(s).
Gate result ⚠️ Not blocking Advisory; not blocking this PR.
Review context
  • Author: kiannidev
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: TypeScript, MDX, C++, HTML, Rust
  • Official Gittensor activity: 1458 PR(s), 48 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.19%. Comparing base (b98229d) to head (d0a6d1f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3599   +/-   ##
=======================================
  Coverage   93.19%   93.19%           
=======================================
  Files         313      313           
  Lines       31874    31874           
  Branches    11666    11666           
=======================================
  Hits        29705    29705           
  Misses       1517     1517           
  Partials      652      652           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JSONbored
JSONbored merged commit bfa9c2d into JSONbored:main Jul 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. manual-review Gittensor contributor context

Development

Successfully merging this pull request may close these issues.

chore(miner-foundation): wire gittensory-engine and gittensory-miner builds into CI

2 participants