test(review): lock advisory==live disposition parity

[luciferlive112116]

Closes #2190

Summary

Add test/unit/advisory-live-parity.test.ts to lock advisory==live parity:

• Gate layer: evaluateGateCheck dry-run displayConclusion matches live-enforcement conclusion on PASS (clean) and FAIL (AI consensus defect) fixtures.
• Execution layer: for the same verdict, only live autonomy schedules terminal merge/close actions; advisory autonomy plans none.

Test-only; no src/ changes. Fixes the self-comparison bug in closed #3685 (�dvisoryComputedSignature used livePlan twice).

Scope

• Conventional Commit title.
• Focused test-only change.
• Follows CONTRIBUTING.md.
• Linked open issue (test(review): regression test locking advisory==live verdict/disposition parity #2190).

Validation

• git diff --check
• npm run typecheck
• npx vitest run test/unit/advisory-live-parity.test.ts (4/4 pass)
• Full CI deferred to GitHub Actions

Safety

• No secrets, no runtime behavior changes, no UI changes.

UI Evidence

N/A — test-only.

Made with Cursor

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[loopover-orb]

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

_{Review updated: 2026-07-06 04:08:53 UTC}

1 file · 1 AI reviewer · no blockers · readiness 62/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This is a test-only addition (test/unit/advisory-live-parity.test.ts) that locks parity between advisory-mode dry-run disposition and live-enforcement conclusion, covering both the gate-evaluation layer (evaluateGateCheck) and the execution layer (planAgentMaintenanceActions), with no src/ changes. The tests are internally coherent: they compare displayConclusion under dry-run+advisory policy to conclusion under live+block policy for both a clean-pass and an AI-consensus-defect fixture, then separately confirm advisory autonomy never schedules a terminal merge/close action while live autonomy does for the same verdict. CI is green and the PR is scoped to a single new test file tied to an open issue (#2190), which is appropriate given the described symptom was in a self-comparison bug in a since-closed PR.

Nits — 6 non-blocking

• The execution-boundary test's `executeTerminal` call-count/order assertion (`toEqual(["merge", "close"])`) implicitly assumes `planAgentMaintenanceActions` yields at most one action of the expected class per case; if that invariant ever changes the test would need updating rather than failing loudly with a clear cause.
• No case exercises the advisory `neutral`/no-findings-but-warning-severity path or a 'neutral' conclusion, only success/failure — consider adding one for fuller parity coverage.
• Test-local helper names like `advisoryWouldBeConclusion`/`liveConclusion` shadow the domain terms fairly closely; a short comment on why dry-run+advisory is the correct proxy for 'what live would do' would help future readers avoid re-litigating the parity assumption.
• Consider adding a fixture where advisory and live modes are expected to diverge (if any legitimately exists) to prove the test isn't vacuously always equal by construction.
• If `GateCheckPolicy`/`AgentActionPlanInput` gain new required fields later, these fixtures will need updates — a comment noting they're intentionally minimal could reduce churn confusion.
• Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.

Signal	Result	Evidence
Code review	✅ No blockers	1 reviewer
Linked issue	✅ Linked	#2190, #3685
Related work	⚠️ 2 scoped overlaps	Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope	❌ 8/20	High review scope from cached public metadata (2 linked issues).
Validation posture	❌ 5/25	Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload	✅ 10/10	Author activity: 173 registered-repo PR(s), 90 merged, 20 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	luciferlive112116; Gittensor profile; 173 PR(s), 20 issue(s).
Gate result	✅ Passing	No configured blocker found.

Review context

• Author: luciferlive112116
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository registration is not available in the local Gittensory cache.
• Public profile languages: JavaScript, MDX, Python, Rust, TypeScript
• Official Gittensor activity: 173 PR(s), 20 issue(s).
• Related work: Items reference the same linked issue test(miner-foundation): engine-parity regression runner (assert extracted === original) #2286. (issue #2286, PR #3687)
• Related work: Open PR work references issue test(miner-foundation): engine-parity regression runner (assert extracted === original) #2286. (issue #2286, PR #3687)

Contributor next steps

• Review top overlaps.
• Add a concise scope and risk note.
• Await review-lane availability.
• Refresh registry data or choose a registered active repo.
• Check active issues and PRs before submitting.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

• Re-run Gittensory review

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.34%. Comparing base (c4c977b) to head (66ab8fd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3689   +/-   ##
=======================================
  Coverage   93.34%   93.34%           
=======================================
  Files         315      315           
  Lines       32129    32129           
  Branches    11780    11780           
=======================================
  Hits        29991    29991           
  Misses       1507     1507           
  Partials      631      631           

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[loopover-orb]

Gittensory approves — the gate is satisfied and CI is green.