Skip to content

docs(config): document shipped review.auto_review knobs in gittensory.full.yml - #3703

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
luciferlive112116:docs/config-auto-review-knobs-2055
Jul 6, 2026
Merged

docs(config): document shipped review.auto_review knobs in gittensory.full.yml#3703
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
luciferlive112116:docs/config-auto-review-knobs-2055

Conversation

@luciferlive112116

Copy link
Copy Markdown
Contributor

Closes #2055

Summary

Validation

  • npx vitest run test/unit/config-templates.test.ts

UI Evidence

N/A

….full.yml

Co-authored-by: Cursor <cursoragent@cursor.com>
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 6, 2026
@loopover-orb

loopover-orb Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-06 05:14:10 UTC

3 files · 1 AI reviewer · no blockers · readiness 80/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This is a pure documentation change that fills in a previously stale "planned, not parsed yet" comment block for four review.auto_review knobs (skip_labels, skip_docs_only, max_added_lines, max_files) that were already implemented in prior PRs (#3686/#3690/#3693 per the description), and adds a regression test asserting the full template documents each field and no longer contains the stale placeholder text. Both YAML template files are kept in sync with identical changes, and the new test in config-templates.test.ts checks for `# field:` comment markers and the absence of "not parsed yet", which matches the diff's content. The change is low-risk, well-scoped to docs/tests, and directly closes the linked issue #2055.

Nits — 4 non-blocking
  • The new test only regexes for `# field:` substrings and doesn't verify the documented defaults/semantics (e.g. max_added_lines default 0 = no cap) actually match the parser's real defaults in src/signals/focus-manifest.ts — worth a follow-up test tying docs to implementation.
  • config/examples/gittensory.full.yml is now right at/over the repo's own long-file heuristic (~407 lines vs 400 threshold per the size-smell note); consider whether the exhaustive template should be split or if that threshold is not meant to apply to config templates.
  • Consider cross-referencing the doc comment's stated defaults (e.g. `max_added_lines` default 0, `max_files` default 0) against the actual default values in the parser to guarantee they can't drift again, similar to how this PR guards against the stale placeholder.
  • If the long-file threshold is a real lint/convention in this repo, note in the PR description why gittensory.full.yml is exempted as an intentionally exhaustive reference doc.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #2055
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 173 registered-repo PR(s), 90 merged, 20 issue(s).
Contributor context ✅ Confirmed Gittensor contributor luciferlive112116; Gittensor profile; 173 PR(s), 20 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: luciferlive112116
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: JavaScript, MDX, Python, Rust, TypeScript
  • Official Gittensor activity: 173 PR(s), 20 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.35%. Comparing base (b39d174) to head (9447c08).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3703   +/-   ##
=======================================
  Coverage   93.35%   93.35%           
=======================================
  Files         315      315           
  Lines       32191    32191           
  Branches    11809    11809           
=======================================
  Hits        30053    30053           
  Misses       1507     1507           
  Partials      631      631           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit 9918acb into JSONbored:main Jul 6, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(config): add exhaustive commented .gittensory.full.yml template

1 participant